Skip waiting for transaction on windows that don't require it

Author: Simeon Kummer

lib/plugins/inventory.js

@@ -631,19 +631,18 @@ function inject (bot, { hideErrors }) {
     if (bot.supportFeature('transactionPacketExists')) {
       const response = once(bot, `confirmTransaction${actionId}`)
       if (!window.transactionRequiresConfirmation(click)) {
-        // Only auto-confirm for inventory window (id 0) clicks
-        // All other window types should wait for server confirmation
-        if (window.id === 0) {
-          confirmTransaction(window.id, actionId, true)
+        // For windows that don't require confirmation (like cartography table on old MC),
+        // skip waiting for server response since it will be rejected anyway
+        confirmTransaction(window.id, actionId, true)
+      } else {
+        const [success] = await withTimeout(response, WINDOW_TIMEOUT)
+          .catch(() => {
+            throw new Error(`Server didn't respond to transaction for clicking on slot ${slot} on window with id ${window?.id}.`)
+          })
+        if (!success) {
+          throw new Error(`Server rejected transaction for clicking on slot ${slot}, on window with id ${window?.id}.`)
         }
       }
-      const [success] = await withTimeout(response, WINDOW_TIMEOUT)
-        .catch(() => {
-          throw new Error(`Server didn't respond to transaction for clicking on slot ${slot} on window with id ${window?.id}.`)
-        })
-      if (!success) {
-        throw new Error(`Server rejected transaction for clicking on slot ${slot}, on window with id ${window?.id}.`)
-      }
     } else {
       await waitForWindowUpdate(window, slot)
     }