Fix velocity plugin: don't interfere with initial login configuration

The velocity plugin was activating during the initial 1.20.2+ login
configuration phase, which is already handled by node-minecraft-protocol.
This caused duplicate finish_configuration packets and disabled physics
during login, making the bot unable to spawn on 1.20.2+ servers.

Changes:
- Only activate configuration phase handling after first spawn
- Remove duplicate finish_configuration write (minecraft-protocol handles it)
- Remove redundant registry_data/select_known_packs listeners
- Fix missing newlines at EOF (lint errors)
- Fix object-shorthand lint warnings

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Simeon Kummer

examples/velocity_manual_resourcepack.js

@@ -53,4 +53,4 @@ bot.on('error', (err) => {
 bot.on('kicked', (reason) => {
   console.log('Kicked:', reason)
   console.log('Note: If kicked during transfer, you may need to enable the velocity plugin')
-})
+})

examples/velocity_transfer.js

@@ -66,4 +66,4 @@ bot.on('error', (err) => {
 
 bot.on('kicked', (reason) => {
   console.log('Kicked:', reason)
-})
+})

lib/plugins/velocity.js

@@ -1,14 +1,13 @@
 /**
  * Velocity proxy support for Minecraft 1.20.2+ configuration phase
  *
- * This plugin manages the configuration phase introduced in Minecraft 1.20.2
- * and extended in 1.21+, which is required for proper server transfers via
- * Velocity proxy.
+ * This plugin manages the re-configuration phase that occurs during
+ * server transfers via Velocity proxy. It does NOT interfere with the
+ * initial login configuration (handled by node-minecraft-protocol).
  *
- * During the configuration phase:
+ * During re-configuration:
  * - Gameplay packets (movement, physics) are not allowed
- * - Only configuration packets should be sent
- * - Resource packs must be handled correctly
+ * - Resource packs must be accepted for the transfer to complete
  *
  * Issue: https://github.com/PrismarineJS/mineflayer/issues/3764
  */
@@ -18,7 +17,10 @@ module.exports = inject
 function inject (bot) {
   // Track whether we're in configuration phase
   bot.inConfigurationPhase = false
-  let configurationFinished = false
+
+  // Only activate after the first spawn -- the initial login configuration
+  // is already handled by node-minecraft-protocol and we must not interfere.
+  let hasInitiallySpawned = false
 
   // Resource pack response codes
   const TEXTURE_PACK_RESULTS = {
@@ -29,13 +31,13 @@ function inject (bot) {
   }
 
   /**
-   * Enter configuration phase
+   * Enter configuration phase (only for re-entry, not initial login)
    */
   function enterConfigurationPhase () {
     if (bot.inConfigurationPhase) return
+    if (!hasInitiallySpawned) return
 
     bot.inConfigurationPhase = true
-    configurationFinished = false
 
     // Disable physics during configuration to prevent movement packets
     if (bot.physicsEnabled !== undefined) {
@@ -54,7 +56,7 @@ function inject (bot) {
 
     bot.inConfigurationPhase = false
 
-    // Re-enable physics after configuration
+    // Re-enable physics after a short delay to let the server finish setup
     setTimeout(() => {
       if (bot._physicsWasEnabled && !bot._ended) {
         bot.physicsEnabled = true
@@ -65,52 +67,39 @@ function inject (bot) {
     bot.emit('configurationPhase', 'end')
   }
 
+  // Mark initial spawn complete -- after this, configuration phase events
+  // are treated as Velocity re-configuration (server transfers).
+  bot.once('spawn', () => {
+    hasInitiallySpawned = true
+  })
+
   // === CONFIGURATION PHASE DETECTION ===
 
-  // Method 1: start_configuration event (1.20.2+)
+  // start_configuration is sent by the server to re-enter config state (1.20.2+)
   bot._client.on('start_configuration', () => {
     enterConfigurationPhase()
   })
 
-  // Method 2: select_known_packs event (1.21+)
-  bot._client.on('select_known_packs', (packet) => {
-    enterConfigurationPhase()
-    // Note: No response needed for select_known_packs
-  })
-
-  // Method 3: registry_data event (1.20.2+)
-  bot._client.on('registry_data', (packet) => {
-    // Only enter if not already in configuration phase
-    // (registry_data can be sent multiple times)
-    if (!bot.inConfigurationPhase) {
-      enterConfigurationPhase()
-    }
-  })
-
-  // Method 4: transfer event (1.20.5+)
-  bot._client.on('transfer', (packet) => {
+  // transfer event (1.20.5+) -- server is transferring us
+  bot._client.on('transfer', () => {
     enterConfigurationPhase()
   })
 
   // === AUTOMATIC RESOURCE PACK ACCEPTANCE ===
 
-  /**
-   * Automatically accept resource packs during configuration phase
-   * This is required for Velocity transfers to complete successfully
-   */
+  // Automatically accept resource packs during configuration phase.
+  // This is required for Velocity transfers to complete -- the server
+  // waits for SUCCESSFULLY_LOADED before sending finish_configuration.
 
   // Handle add_resource_pack (1.20.3+)
   bot._client.prependListener('add_resource_pack', (data) => {
     if (!bot.inConfigurationPhase) return
 
-    // Send ACCEPTED immediately
     bot._client.write('resource_pack_receive', {
       uuid: data.uuid,
       result: TEXTURE_PACK_RESULTS.ACCEPTED
     })
 
-    // Send SUCCESSFULLY_LOADED immediately
-    // Server needs this before sending finish_configuration
     bot._client.write('resource_pack_receive', {
       uuid: data.uuid,
       result: TEXTURE_PACK_RESULTS.SUCCESSFULLY_LOADED
@@ -120,52 +109,35 @@ function inject (bot) {
   // Handle resource_pack_send (older versions with UUID support)
   bot._client.prependListener('resource_pack_send', (data) => {
     if (!bot.inConfigurationPhase) return
-    if (!data.uuid) return // Only handle UUID-based resource packs
+    if (!data.uuid) return
 
     const UUID = require('uuid-1345')
-    const uuid = new UUID(data.uuid)
+    const resourceUuid = new UUID(data.uuid)
 
-    // Send ACCEPTED immediately
     bot._client.write('resource_pack_receive', {
-      uuid: uuid,
+      uuid: resourceUuid,
       result: TEXTURE_PACK_RESULTS.ACCEPTED
     })
 
-    // Send SUCCESSFULLY_LOADED immediately
     bot._client.write('resource_pack_receive', {
-      uuid: uuid,
+      uuid: resourceUuid,
       result: TEXTURE_PACK_RESULTS.SUCCESSFULLY_LOADED
     })
   })
 
-  // === FINISH CONFIGURATION ===
+  // === EXIT CONFIGURATION ===
 
+  // node-minecraft-protocol already writes the finish_configuration
+  // acknowledgement and transitions to PLAY state. We just need to
+  // track it so we can re-enable physics.
   bot._client.on('finish_configuration', () => {
-    configurationFinished = true
-
-    // Acknowledge finish_configuration
-    try {
-      bot._client.write('finish_configuration', {})
-    } catch (err) {
-      // Ignore if packet doesn't exist for this version
-    }
-
-    // Exit configuration phase after a short delay
+    // Small delay to let the play state fully initialize
     setTimeout(() => {
       exitConfigurationPhase()
     }, 500)
   })
 
-  // === FALLBACKS ===
-
-  // Fallback: Exit on login if we're still in configuration phase
-  bot.on('login', () => {
-    if (bot.inConfigurationPhase && configurationFinished) {
-      exitConfigurationPhase()
-    }
-  })
-
-  // Fallback: Exit on spawn if we're still in configuration phase
+  // Fallback: exit on spawn if we're still in configuration phase
   bot.on('spawn', () => {
     if (bot.inConfigurationPhase) {
       exitConfigurationPhase()
@@ -175,6 +147,6 @@ function inject (bot) {
   // Cleanup on end
   bot.on('end', () => {
     bot.inConfigurationPhase = false
-    configurationFinished = false
+    delete bot._physicsWasEnabled
   })
-}
+}