Crafting is slow

[demipixel]

I've had experience and @roblabla suggested that I make a post about since he believes we're doing a lot of unnecessary work.

In some cases I can craft faster than the bot.

[roblabla]

I believe we shouldn't be waiting after each click for the transaction to complete. Instead, we could send all clicks at once (except the final one), check if we got any errors, and if we didn't send the final click.

[rom1504]

Yeah I guess we could optimize it. It might even not be very hard since nobody tried yet afaik (craft was broken not long ago).

[rom1504]

related to #129

[rom1504]

244fc7b improves bot.transfer by left clicking when possible instead of always right clicking, bot.craft could probably be improved in a similar way (using different kind of clicks)

[FeldrinH]

In minecraft 1.12 and above, fast crafting could be achieved by using craft recipe request packet to move items into the crafting grid (multiple consecutive packets can be sent to increase the number of items in the crafting grid), and a shift click to withdraw all items at once.

[sefirosweb]

Checking this issue, the slow performance comes for waiting to open window,
I measured all steps to craft items and this step are the 98% of lost time

mineflayer/lib/plugins/craft.js

Line 24 in 2086273

const [window] = await once(bot, 'windowOpen')

What I don't quite understand is that the FIRST execution takes only 22ms,

But if another crafting is requested shortly (example x 64 items) the second request takes 900ms~ why? I think it is due to a windowOpen failure

I attach the perform test:

Of course it could be optimized to not close the window and finish crafting, but I think it would be important to see why it takes so long to open the window

[rom1504]

there are at least 2 PRs solving this issue but they didn't get finished

you could pick one and finish it

[sefirosweb]

@rom1504 yep i'm on it, only are notifying on people if know why happens to save time =P

[sefirosweb]

fixed bug! now flies!