Allow custom time-out for openchest

[unnown]

When trying to open more than 10 chests that can't be opened an error will occur due to max number of listener. a fix for this would be a failed event, a configurable time-out that removes the listener, or a way to remove the listener

[roblabla]

@unnown Is it really an error, or just a warning ?

[rom1504]

What is a chest that can't be opened ?

[roblabla]

@rom1504 custom bukkit behavior. Some plugins in bukkit allow you to "lock" a chest so only the owner of that chest can open it. http://dev.bukkit.org/bukkit-plugins/lockette/ or http://dev.bukkit.org/bukkit-plugins/lwc/ are examples of such plugin (see why I say it's useful to cancel stuff ? :D)

[rom1504]

Ah right, these dirty bukkit plugins :p

So yeah obviously this is totally untested, what kind of event does it emit @unnown ? I'm surprised this even work a little bit, since mineflayer currently completely assume vanilla behavior.

[unnown]

This is the exact error btw:
(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.

Note: ofcourse increasing this limit would work, but that would be a very dirty solution (imho) i rather just cancel the listener

Why go so far as bukkit?
it's easy enough to do with 11 chests with a block on top, but that would be testable.
but if there is a block between the bot and the chest it would also fail (even if the distance is close enough)
a chest that is simply out of reach (to high)
there are a lot of reasons that could cause a bot not being able to open a chest.

the reason i'm doing this is because i want to automate potion brewing and the bot needs to 'identify' the chests containing the ingredients in a room with several chests (including these pesky 'protected' chests)

[rom1504]

Okay I understand, I never tried to open a chest that couldn't be opened, I'm not sure what happens in that case. I'll try ;)

About the warning : it's a warning, not an error, that alone is not really your problem. (node is just saying "you are doing somewhere weird, I don't see why you would do that" but it won't cause problem directly)

What is your code to open all these chests ? Anything special ?

[unnown]

the code isn't that complicated,
(chest layout is basicly a 6*7 grid of double chests)

find all chests, (remove double chests),
sort them so you don't move around to much

move to first chest,

see if you are close enough (distance check)
try to open it,
if open than check out items and add the chest to it's specific list
and a timer to go to the next chest (if the chest open is never run, this fires the next chest)

go to the next chest

[rom1504]

Maybe you could paste your code ? just to be sure the pb is not coming from that

[unnown]

This is quickly writen code, do not pay attention to how it looks.
it just keeps adding listeners that never get removed, and it would be nice to add some customizable timeout to automaticly remove them or something.

[unnown]

var mineflayer = require('mineflayer');
var navigatePlugin = require('mineflayer-navigate')(mineflayer);
var blockFinderPlugin = require('mineflayer-blockfinder')(mineflayer);

var chestBlock = new Array();
var currBlock = 0;

var bot = mineflayer.createBot({
  host: "", // optional
  port: 25565,       // optional
  username: "", // email and password are required only for
  password: "",          // online-mode=true servers
});

navigatePlugin(bot);
blockFinderPlugin(bot);

bot.navigate.on('interrupted', function() { console.log('interrupted'); });
bot.navigate.on('pathFound', function (path) { console.log('pathFound'); });
bot.navigate.on('cannotFind', function (closestPath) { bot.navigate.walk(closestPath); });

bot.navigate.on('arrived', function () {
    console.log('arrived');
    arrived();
});

function assumeArrived() {
    console.log('assumed');
    arrived();
}

function arrived() {
    var chest = bot.openChest(chestBlock[currBlock]);
    timer = setTimeout(function(){ nextChest(); }, 3000);
    chest.on('open', function() {
        clearTimeout(timer);
        nextChest();
    });
};

function nextChest() {
    if (currBlock < chestBlock.length) {
        currBlock++;
        console.log(currBlock);
        bot.navigate.to(chestBlock[currBlock].position);
        setTimeout(function(){ assumeArrived(); }, 1500);
    }
}

function findChest() {
     bot.findBlock({
        point: bot.entity.position,
        matching: [54, 130, 146],
        maxDistance: 30,
        count: 20,
      }, function(err, blockPoints) {
        if (err) {
            console.log(err);
            return;
        }

        if (blockPoints.length) {
            console.log('found the block');
            chestBlock = blockPoints;
            return;
        } else {
            return;
        }
      });   

    if(!chestBlock) {
        return;
    }     

    bot.navigate.to(chestBlock[currBlock].position);
    setTimeout(function(){ assumeArrived(); }, 1500);
}

bot.once('spawn', function() {
    console.log('bot.game.dimension: ' + bot.game.dimension);
    setTimeout(function(){ findChest(); }, 5000);
});

[Darthfett]

I'm curious, would a chest with an opaque block above it also be considered a 'chest that can't be opened'?

[unnown]

depends on the block, redstone block, glowstone, those things allow a chest to still be opened anything minecraft thinks is transparent

[Gjum]

@Darthfett on vanilla yes. On modded servers, you can make any block open an inventory, even chests with blocks above.