Support spigot

[rom1504]

Lot of users want to use mineflayer on spigot, and we basically never tested it there.
Apparently spigot do some stuff differently:

• "spawn" event
• bot.players

Best way would be to add spigot to the automatic tests there https://github.com/andrewrk/mineflayer/blob/master/test/externalTest.js

Last person to want spigot support is @darkfield

[rom1504]

First thing here is automating the downloading of spigot.
See https://www.spigotmc.org/wiki/buildtools/ and https://hub.spigotmc.org/jenkins/job/BuildTools/

[rom1504]

spigot takes like 10-15min to build, it would probably be unreasonable to put that in the circle ci tests

edit: the resulting jar is 19M, maybe this could go in a circle ci thing for storing files ?

[rom1504]

Alright I checked manually, both the spawn event and bot.players work perfectly on spigot.

Letting that issue open to track further testing on spigot.

[rom1504]

I tried, all the mineflayer tests pass on spigot.

[rom1504]

Ah wget http://getspigot.org/spigot18/spigot_server.jar does it too

[rom1504]

Some work need to be done to make external.js support multiple servers (like node-minecraft-protocol tests do) and the downloading of spigot need to be added to node-minecraft-wrap.

[wvffle]

We can use Yivesmirror API for downloading another server cores.
Practical example is in one of my repos: spigot-updater

[rom1504]

Sounds good, that can he integrated in node-minecraft-wrap

…

On Thu, May 16, 2019, 10:25 Kasper Seweryn ***@***.***> wrote: We can use Yivesmirror API <https://yivesmirror.com/apis> for downloading another server cores. Practical example is in one of my repos: spigot-updater <https://github.com/wvffle/spigot-updater/blob/master/lib/updater/server.js> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#346?email_source=notifications&email_token=AAR437S4MAJKJ6PQAJTE7XDPVUK7FA5CNFSM4BXCR7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRCBXQ#issuecomment-492970206>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR437SKUVTSTE3SOKZVSMTPVUK7FANCNFSM4BXCR7PQ> .