Add cartography table plugin (lint-fixed version of #3778)#3826
Open
plainprince wants to merge 25 commits intoPrismarineJS:masterfrom
Open
Add cartography table plugin (lint-fixed version of #3778)#3826plainprince wants to merge 25 commits intoPrismarineJS:masterfrom
plainprince wants to merge 25 commits intoPrismarineJS:masterfrom
Conversation
Based on PrismarineJS#3778 by @AboveAphid. Adds ability to use cartography tables (put/take maps, modifiers, and outputs). Fixes lint errors (space-before-function-paren, padded-blocks) that caused CI to fail. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Please add tests |
plainprince
force-pushed
the
fix/cartography-table-lint
branch
from
cc06c55 to
6d3818e
Compare
…prince/mineflayer into fix/cartography-table-lint
Contributor
Author
|
Well, it seems the CI has "some" problems. |
added 6 commits
April 15, 2026 17:08
… operations - Fix activateItem: use actual bot entity rotation in use_item packet - Fix heldItemChanged test: use bot._setSlot instead of updateSlot - Add wait after cartography take operations for transaction handling
- Add 'minecraft:generic' to allowed window types for 1.19+ - Use moveSlotItem instead of transfer for put operations - Fix chunk packet generation for newer versions (bitMap computing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/plugins/cartography_table.js) enabling bot interaction with cartography tables (put/take maps, modifiers, and outputs)lib/loader.jsand documents the API indocs/api.mdChanges from #3778
Fixed all
standardlint errors incartography_table.js:space-before-function-paren)padded-blocks)Note on 1.13.2 CI failure
The
useCheststest failure on 1.13.2 (27 !== 305) in #3778 is a pre-existing flaky test unrelated to these changes -- master CI passes consistently.Test plan
npm run lintpasses locallyMade with Cursor