Fix the minor defects found by adversarial review of the 6.2.13 diff

An adversarial multi-agent review of the release diff returned no blocking or
major findings; these are the two minor items in the new code plus two format
conformance nits. No functional change to the server core.

  - DBUpdater recorded UpgradeSucceeded only after ReleaseComObject and
    Reinitialize, so a COM/RPC failure during that cleanup reported a schema
    upgrade that had already committed as a failure (and the installer then
    showed the new "could not be created or upgraded" error). Success is now
    recorded immediately after CommitTransaction succeeds.

  - DBSetup returned void, so the installer's new exit-code check was inert on
    the external-database branch and a cancelled or incomplete interactive
    setup still reported install success. Main now returns 0 only when the
    wizard reached its final page (a page advances only when its task
    succeeded), 3 when authentication is cancelled, else 1.

  - SpamAssassinClient formatted the widened __int64 Content-length and the
    size-mismatch log value with %d; both now use %I64d. The emitted values
    were correct on x64, so this is conformance only.

Deferred to 6.2.14 (raised by the same review, not a regression): the PTR
prefetch task shares the bounded asynchronous work queue with message
finalization, so many simultaneous connections from addresses with
unresponsive reverse DNS can delay delivery responses. It is strictly better
than 6.2.12, which blocked the shared IO pool. The fix is a dedicated queue or
a bounded DnsQueryEx timeout.

Verified: server and tools build clean (server /WX, tools -warnaserror); full
regression suite 1026 of 1026 passing against the rebuilt 6.2.13 service.

Author: chrisholloway5

hmailserver/source/Server/Common/AntiSpam/SpamAssassin/SpamAssassinClient.cpp

@@ -59,7 +59,7 @@ namespace HM
       EnqueueWrite("PROCESS SPAMC/1.2\r\n");
 	  //LOG_DEBUG("SENT: PROCESS SPAMC/1.2");
 	  String sConLen;
-	  sConLen.Format(_T("Content-length: %d\r\n"), message_size_);
+	  sConLen.Format(_T("Content-length: %I64d\r\n"), message_size_);
 	  EnqueueWrite(sConLen);
 	  EnqueueWrite("\r\n");
      SendFileContents_(message_file_);
@@ -240,7 +240,7 @@ namespace HM
      else 
      {
 		 String logMessage;
-		 logMessage.Format(_T("SA: Temp file size did not match what Spamd reported! (temp: %d, spamd: %d). Reverting to original message file."),FileUtilities::FileSize(sTempFile),spam_dsize_);
+		 logMessage.Format(_T("SA: Temp file size did not match what Spamd reported! (temp: %d, spamd: %I64d). Reverting to original message file."),FileUtilities::FileSize(sTempFile),spam_dsize_);
          LOG_DEBUG(logMessage);
 	  }
 

hmailserver/source/Tools/DBSetup/Program.cs

@@ -11,23 +11,33 @@ namespace DBSetup
 {
    static class Program
    {
+      // Exit codes consumed by the installer: a cancelled or incomplete database
+      // setup must not look like a successful install.
+      private const int ExitSuccess = 0;
+      private const int ExitSetupIncomplete = 1;
+      private const int ExitAuthenticationCancelled = 3;
+
       /// <summary>
       /// The main entry point for the application.
       /// </summary>
       [STAThread]
-      static void Main()
+      static int Main()
       {
          ToolApplication.Initialize();
 
          CommandLineParser.Parse();
-         
+
          hMailServer.Application application = new hMailServer.Application();
          if (!Authenticator.AuthenticateUser(application))
-            return;
+            return ExitAuthenticationCancelled;
 
          Globals.SetApp(application);
 
-         Application.Run(new formMain());
+         formMain main = new formMain();
+         Application.Run(main);
+
+         // Closing the wizard before it finished leaves the database unconfigured.
+         return main.SetupCompleted ? ExitSuccess : ExitSetupIncomplete;
       }
    }
 }

hmailserver/source/Tools/DBSetup/formMain.cs

@@ -14,6 +14,14 @@ namespace DBSetup
 {
    public partial class formMain : Form
    {
+      /// <summary>
+      /// True once the wizard reached its final page. A page only advances when
+      /// IWizardPage.OnLeavePage succeeds, so reaching the last page means the
+      /// create/update task actually completed. Program.Main turns this into the
+      /// process exit code the installer checks.
+      /// </summary>
+      public bool SetupCompleted { get; private set; }
+
       public formMain()
       {
          InitializeComponent();
@@ -42,6 +50,9 @@ private void formMain_Shown(object sender, EventArgs e)
       private void wizard_PageChanged(int currentPage, int lastPage)
       {
          this.Text = "hMailServer Database Setup - Step " + currentPage + " of " + lastPage;
+
+         if (currentPage == lastPage)
+            SetupCompleted = true;
       }
    }
 }

hmailserver/source/Tools/DBUpdater/formMain.cs

@@ -405,15 +405,18 @@ public void DoUpgrade()
                return;
             }
 
+            // The schema is committed from here on, so record success before the
+            // cleanup below: a COM/RPC failure while reinitializing must not report
+            // an upgrade that did happen as a failure.
+            UpgradeSucceeded = true;
+
             Marshal.ReleaseComObject(database);
 
             // Database has been upgraded. Reinitialize the connections.
             _application.Reinitialize();
 
             RemoveErrorLog();
 
-            UpgradeSucceeded = true;
-
             buttonClose.Enabled = true;
          }