[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Author: pre-commit-ci[bot]

monailabel/datastore/utils/convert_htj2k.py

@@ -1049,9 +1049,13 @@ def convert_single_frame_dicom_series_to_multiframe(
             # Save ImageOrientationPatient and ImagePositionPatient BEFORE creating output_ds
             # The shallow copy + delattr will affect the original datasets objects
             # Save these values now so we can use them in functional groups later
-            original_image_orientation = datasets[0].ImageOrientationPatient if hasattr(datasets[0], "ImageOrientationPatient") else None
-            original_image_positions = [ds.ImagePositionPatient if hasattr(ds, "ImagePositionPatient") else None for ds in datasets]
-            
+            original_image_orientation = (
+                datasets[0].ImageOrientationPatient if hasattr(datasets[0], "ImageOrientationPatient") else None
+            )
+            original_image_positions = [
+                ds.ImagePositionPatient if hasattr(ds, "ImagePositionPatient") else None for ds in datasets
+            ]
+
             # Create SIMPLE multi-frame DICOM file (like the user's example)
             # Use first dataset as template, keeping its metadata
             logger.info(f"  Creating simple multi-frame DICOM from {total_frame_count} frames...")
@@ -1108,19 +1112,28 @@ def convert_single_frame_dicom_series_to_multiframe(
             # CRITICAL: Remove top-level ImagePositionPatient and ImageOrientationPatient
             # Working files (that display correctly in OHIF MPR) have NEITHER at top level
             # These should ONLY exist in functional groups for Enhanced CT
-            
+
             if hasattr(output_ds, "ImagePositionPatient"):
                 delattr(output_ds, "ImagePositionPatient")
                 logger.info(f"  ✓ Removed top-level ImagePositionPatient (use per-frame only)")
-            
+
             if hasattr(output_ds, "ImageOrientationPatient"):
                 delattr(output_ds, "ImageOrientationPatient")
                 logger.info(f"  ✓ Removed top-level ImageOrientationPatient (use SharedFunctionalGroupsSequence only)")
             # Set correct SOPClassUID for multi-frame (Enhanced/Multiframe) conversion
             sopclass_map = {
-                "1.2.840.10008.5.1.4.1.1.2":   ("1.2.840.10008.5.1.4.1.1.2.1",   "Enhanced CT Image Storage"),                  # CT -> Enhanced CT
-                "1.2.840.10008.5.1.4.1.1.4":   ("1.2.840.10008.5.1.4.1.1.4.1",   "Enhanced MR Image Storage"),                  # MR -> Enhanced MR
-                "1.2.840.10008.5.1.4.1.1.6.1": ("1.2.840.10008.5.1.4.1.1.3.1",   "Ultrasound Multi-frame Image Storage"),       # US -> Ultrasound Multi-frame
+                "1.2.840.10008.5.1.4.1.1.2": (
+                    "1.2.840.10008.5.1.4.1.1.2.1",
+                    "Enhanced CT Image Storage",
+                ),  # CT -> Enhanced CT
+                "1.2.840.10008.5.1.4.1.1.4": (
+                    "1.2.840.10008.5.1.4.1.1.4.1",
+                    "Enhanced MR Image Storage",
+                ),  # MR -> Enhanced MR
+                "1.2.840.10008.5.1.4.1.1.6.1": (
+                    "1.2.840.10008.5.1.4.1.1.3.1",
+                    "Ultrasound Multi-frame Image Storage",
+                ),  # US -> Ultrasound Multi-frame
             }
 
             original_sopclass = getattr(datasets[0], "SOPClassUID", None)
@@ -1186,7 +1199,9 @@ def convert_single_frame_dicom_series_to_multiframe(
                 else:
                     # If missing, use default (0,0,frame_idx * spacing)
                     # This shouldn't happen for valid CT series, but ensures MPR compatibility
-                    default_spacing = float(output_ds.SpacingBetweenSlices) if hasattr(output_ds, 'SpacingBetweenSlices') else 1.0
+                    default_spacing = (
+                        float(output_ds.SpacingBetweenSlices) if hasattr(output_ds, "SpacingBetweenSlices") else 1.0
+                    )
                     plane_pos_item.ImagePositionPatient = [0.0, 0.0, frame_idx * default_spacing]
                     logger.warning(f"    Frame {frame_idx} missing ImagePositionPatient, using default")
                 frame_item.PlanePositionSequence = Sequence([plane_pos_item])

tests/unit/datastore/test_convert_htj2k.py

@@ -786,7 +786,9 @@ def test_transcode_dicom_to_htj2k_multiframe_metadata(self):
             first_original = original_datasets[0]
 
             # Check ImagePositionPatient is NOT there at top level DICOM file
-            self.assertFalse(hasattr(ds_multiframe, "ImagePositionPatient"), "Should not have ImagePositionPatient at top level")
+            self.assertFalse(
+                hasattr(ds_multiframe, "ImagePositionPatient"), "Should not have ImagePositionPatient at top level"
+            )
 
             # Check PixelSpacing
             self.assertTrue(hasattr(ds_multiframe, "PixelSpacing"), "Should have PixelSpacing")
@@ -812,31 +814,31 @@ def test_transcode_dicom_to_htj2k_multiframe_metadata(self):
             # Check SOPClassUID conversion to Enhanced/Multi-frame
             self.assertTrue(hasattr(ds_multiframe, "SOPClassUID"), "Should have SOPClassUID")
             self.assertTrue(hasattr(first_original, "SOPClassUID"), "Original should have SOPClassUID")
-            
+
             # Map of single-frame to enhanced/multi-frame SOPClassUIDs
             sopclass_map = {
-                "1.2.840.10008.5.1.4.1.1.2": "1.2.840.10008.5.1.4.1.1.2.1",     # CT -> Enhanced CT
-                "1.2.840.10008.5.1.4.1.1.4": "1.2.840.10008.5.1.4.1.1.4.1",     # MR -> Enhanced MR
-                "1.2.840.10008.5.1.4.1.1.6.1": "1.2.840.10008.5.1.4.1.1.3.1",   # US -> Ultrasound Multi-frame
+                "1.2.840.10008.5.1.4.1.1.2": "1.2.840.10008.5.1.4.1.1.2.1",  # CT -> Enhanced CT
+                "1.2.840.10008.5.1.4.1.1.4": "1.2.840.10008.5.1.4.1.1.4.1",  # MR -> Enhanced MR
+                "1.2.840.10008.5.1.4.1.1.6.1": "1.2.840.10008.5.1.4.1.1.3.1",  # US -> Ultrasound Multi-frame
             }
-            
+
             original_sopclass = str(first_original.SOPClassUID)
             multiframe_sopclass = str(ds_multiframe.SOPClassUID)
-            
+
             if original_sopclass in sopclass_map:
                 expected_sopclass = sopclass_map[original_sopclass]
                 self.assertEqual(
                     multiframe_sopclass,
                     expected_sopclass,
-                    f"SOPClassUID should be converted from {original_sopclass} to {expected_sopclass}"
+                    f"SOPClassUID should be converted from {original_sopclass} to {expected_sopclass}",
                 )
                 print(f"✓ SOPClassUID converted: {original_sopclass} -> {multiframe_sopclass}")
             else:
                 # If not in map, should remain unchanged
                 self.assertEqual(
                     multiframe_sopclass,
                     original_sopclass,
-                    "SOPClassUID should remain unchanged if not in conversion map"
+                    "SOPClassUID should remain unchanged if not in conversion map",
                 )
                 print(f"✓ SOPClassUID unchanged: {multiframe_sopclass}")