improving test coverage

Signed-off-by: Neil South <[email protected]>

Author: neildsouth

src/Database/MongoDB/Integration.Test/SourceApplicationEntityRepositoryTest.cs

@@ -113,6 +113,20 @@ public async Task GivenAAETitleName_WhenFindByNameAsyncIsCalled_ExpectItToReturn
             Assert.Null(actual);
         }
 
+        [Fact]
+        public async Task GivenAETitle_WhenFindByAETitleAsyncIsCalled_ExpectItToReturnMatchingEntity()
+        {
+            var store = new SourceApplicationEntityRepository(_serviceScopeFactory.Object, _logger.Object, _options, _databaseFixture.Options);
+
+            var actual = await store.FindByAETAsync("AET1").ConfigureAwait(false);
+            Assert.NotNull(actual);
+            Assert.Equal("AET1", actual.FirstOrDefault()!.AeTitle);
+            Assert.Equal("AET1", actual.FirstOrDefault()!.Name);
+
+            actual = await store.FindByAETAsync("AET6").ConfigureAwait(false);
+            Assert.Empty(actual);
+        }
+
         [Fact]
         public async Task GivenASourceApplicationEntity_WhenRemoveIsCalled_ExpectItToDeleted()
         {
@@ -158,5 +172,7 @@ public async Task GivenASourceApplicationEntity_WhenUpdatedIsCalled_ExpectItToSa
             Assert.NotNull(dbResult);
             Assert.Equal(expected.AeTitle, dbResult!.AeTitle);
         }
+
+
     }
 }

src/InformaticsGateway/Test/Services/Http/SourceAeTitleControllerTest.cs

@@ -196,6 +196,24 @@ public async Task GetAeTitle_ShallReturnProblemOnFailure()
             _repository.Verify(p => p.FindByNameAsync(value, It.IsAny<CancellationToken>()), Times.Once());
         }
 
+        [RetryFact(5, 250, DisplayName = "GetAeTitle from AETitle - Shall return problem on failure")]
+        public async Task GetAeTitleViaAETitle_ShallReturnProblemOnFailure()
+        {
+            var value = "AET";
+            _repository.Setup(p => p.FindByAETAsync(It.IsAny<string>(), It.IsAny<CancellationToken>())).Throws(new Exception("error"));
+
+            var result = await _controller.GetAeTitleByAET(value);
+
+            var objectResult = result.Result as ObjectResult;
+            Assert.NotNull(objectResult);
+            var problem = objectResult.Value as ProblemDetails;
+            Assert.NotNull(problem);
+            Assert.Equal("Error querying DICOM sources.", problem.Title);
+            Assert.Equal("error", problem.Detail);
+            Assert.Equal((int)HttpStatusCode.InternalServerError, problem.Status);
+            _repository.Verify(p => p.FindByAETAsync(value, It.IsAny<CancellationToken>()), Times.Once());
+        }
+
         #endregion GetAeTitle
 
         #region Create