Code analysis fixes.

Signed-off-by: JP LEGER <[email protected]>

Author: jeanpatrickleger

src/Messaging/SQS/README.MD

@@ -96,7 +96,7 @@ The plugin is configured in the Messaging section of `appsettings.json` / `appse
 
 ```json
     "messaging": {
-      "publisherServiceAssemblyName": "Monai.Deploy.Messaging.SQS.SQSMessagePublisherService, Monai.Deploy.Messaging",
+      "publisherServiceAssemblyName": "Monai.Deploy.Messaging.SQS.SqsMessagePublisherService, Monai.Deploy.Messaging",
       "subscriberServiceAssemblyName": "Monai.Deploy.Messaging.SQS.SqsMessageSubscriberService, Monai.Deploy.Messaging",
       "publisherSettings": {
         "bucketName": "monai-minio",

src/Messaging/SQS/SQSMessagePublisherService.cs

@@ -14,11 +14,11 @@
 
 namespace Monai.Deploy.Messaging.SQS
 {
-    public class SQSMessagePublisherService : IMessageBrokerPublisherService
+    public class SqsMessagePublisherService : IMessageBrokerPublisherService
     {
         private const int PersistentDeliveryMode = 2;
 
-        private readonly ILogger<SQSMessagePublisherService> _logger;
+        private readonly ILogger<SqsMessagePublisherService> _logger;
         private readonly string? _accessKey;
         private readonly string? _accessToken;
         private readonly string _environmentId = string.Empty;
@@ -32,8 +32,8 @@ public class SQSMessagePublisherService : IMessageBrokerPublisherService
         private readonly AmazonS3Client? _s3Client;
         private readonly AmazonSQSExtendedClient? _sqSExtendedClient;
 
-        public SQSMessagePublisherService(IOptions<MessageBrokerServiceConfiguration> options,
-                                               ILogger<SQSMessagePublisherService> logger)
+        public SqsMessagePublisherService(IOptions<MessageBrokerServiceConfiguration> options,
+                                               ILogger<SqsMessagePublisherService> logger)
         {
             Guard.Against.Null(options, nameof(options));
 
@@ -42,8 +42,6 @@ public SQSMessagePublisherService(IOptions<MessageBrokerServiceConfiguration> op
             var configuration = options.Value;
             ValidateConfiguration(configuration);
 
-
-            //This 2 config entries are mandatory.
             _queueName = configuration.PublisherSettings[SQSConfigurationKeys.WorkflowRequestQueue];
             _bucketName = configuration.PublisherSettings[SQSConfigurationKeys.BucketName];
 
@@ -176,7 +174,7 @@ public Task Publish(string topic, Monai.Deploy.Messaging.Messages.Message messag
             {
                 SendMessageResponse sqsresp = _sqSExtendedClient.SendMessageAsync(sendMessageRequest).Result;
             }
-            catch(Exception e)
+            catch (Exception e)
             {
                 _logger.LogError($"The message could not be posted to the queue {queueName} : \n {e.Message}");
             }

src/Messaging/SQS/SQSMessageSubscriberService.cs

@@ -188,14 +188,13 @@ public void SubscribeAsync(string[] topics, string queue, Func<MessageReceivedEv
 
         public void Acknowledge(MessageBase message)
         {
-            //We will use this to delelete the message from the SQS qeue.
+            //No Acknowleddgement necessary with SQS. To delete the processed message is sufficient.
         }
 
         public void Reject(MessageBase message, bool requeue = true)
         {
             Guard.Against.Null(message, nameof(message));
 
-
         }
 
         protected virtual void Dispose(bool disposing)
@@ -206,7 +205,6 @@ protected virtual void Dispose(bool disposing)
                 {
 
                 }
-
                 _disposedValue = true;
             }
         }
@@ -232,7 +230,7 @@ private static MessageReceivedEventArgs CreateMessage(Amazon.SQS.Model.Message m
             return new MessageReceivedEventArgs(
                 new Monai.Deploy.Messaging.Messages.Message(
                 body: Encoding.UTF8.GetBytes(msg.Body),
-                messageDescription: "desc1",
+                messageDescription: msg.MessageAttributes["ContentType"].ToString(),
                 messageId: bodyobj["MessageId"].ToString(),
                 applicationId: msg.Attributes["SenderId"],
                 contentType: msg.MessageAttributes["ContentType"].ToString(),