fix voice bridge action arbitration

Author: MomiJiSan

app/agent_server.py

@@ -1680,6 +1680,11 @@ def _voice_bridge_action_from_dispatch_results(dispatch_results: object) -> Dict
     if not isinstance(dispatch_results, list) or not dispatch_results:
         return _voice_bridge_noop("no_subscribers")
 
+    from plugin.plugins.study_companion.voice_contracts import (
+        arbitrate_voice_transcript_results,
+    )
+
+    arbitration_items: list[dict[str, object]] = []
     failure_count = 0
     for item in dispatch_results:
         if not isinstance(item, Mapping):
@@ -1701,9 +1706,25 @@ def _voice_bridge_action_from_dispatch_results(dispatch_results: object) -> Dict
         source_event_id = str(item.get("event_id") or "").strip()
         if source_event_id:
             payload.setdefault("source_event_id", source_event_id)
-        return payload
+        arbitration_items.append(
+            {
+                "plugin_id": payload.get("source_plugin") or plugin_id,
+                "event_id": payload.get("source_event_id") or source_event_id,
+                "success": True,
+                "result": payload,
+            }
+        )
 
-    return _voice_bridge_noop("no_handler_result", failures=failure_count)
+    if not arbitration_items:
+        return _voice_bridge_noop("no_handler_result", failures=failure_count)
+    payload = arbitrate_voice_transcript_results(arbitration_items)
+    if failure_count:
+        try:
+            existing_failures = int(payload.get("failures") or 0)
+        except (TypeError, ValueError):
+            existing_failures = 0
+        payload["failures"] = existing_failures + failure_count
+    return payload
 
 
 async def _dispatch_voice_transcript_custom_event(

tests/unit/test_agent_server_voice_bridge.py

@@ -175,9 +175,49 @@ async def _trigger_custom_event_subscribers(
     }
     assert emitted["event_type"] == "voice_bridge_result"
     assert emitted["payload"]["event_id"] == "voice-2"
-    assert emitted["payload"]["result"] == {
-        "action": "prime_context",
-        "context": "screen context",
-        "source_plugin": "study_companion",
-        "source_event_id": "handle_transcript",
-    }
+    result = emitted["payload"]["result"]
+    assert result["action"] == "prime_context"
+    assert result["context"] == "screen context"
+    assert result["source_plugin"] == "study_companion"
+    assert result["source_event_id"] == "handle_transcript"
+
+
+def test_voice_bridge_dispatch_results_are_arbitrated() -> None:
+    from app import agent_server as srv
+
+    result = srv._voice_bridge_action_from_dispatch_results(
+        [
+            {
+                "plugin_id": "context_plugin",
+                "event_id": "prime",
+                "success": True,
+                "result": {
+                    "action": "prime_context",
+                    "context": "screen context",
+                    "priority": 100,
+                },
+            },
+            {
+                "plugin_id": "study_companion",
+                "event_id": "handle_transcript",
+                "success": True,
+                "result": {
+                    "action": "cancel_response",
+                    "reason": "ocr_overlap",
+                    "priority": -10,
+                },
+            },
+            {
+                "plugin_id": "broken",
+                "event_id": "voice",
+                "success": False,
+                "error": "timeout",
+            },
+        ]
+    )
+
+    assert result["action"] == "cancel_response"
+    assert result["reason"] == "ocr_overlap"
+    assert result["source_plugin"] == "study_companion"
+    assert result["source_event_id"] == "handle_transcript"
+    assert result["failures"] == 1