Upgrade to latest polkadot with frequency _1.17.8_ (#990)

- siwf@latest
- frequency-chain/ethereum-utils
- frequency-scenario-template@latest
- polkadot-api version that matches what's used by all of the above
- stop exposing siwfv1 endpoints
- take care of _some_ npm audit results
- Added @frequency-chain/[email protected] to npm overrides to prevent
version conflicts
- Fixed TypeScript type issue in polkadot-api.service.ts
  - Added import type { u64 } from @polkadot/types-codec
  - Changed Codec?.toNumber() to (... as u64)?.toNumber()
- Root cause: TypeScript type inference became stricter in @polkadot/api
16.4.3→16.4.8

Co-authored-by: shannonwells <[email protected]>

Author: saraswatpuneet

apps/account-api/k6-test/package-lock.json

@@ -1,20 +1,6 @@
 import { AccountsService } from '#account-api/services/accounts.service';
 import { AccountResponseDto, RetireMsaPayloadResponseDto } from '#types/dtos/account/accounts.response.dto';
-import { WalletLoginRequestDto } from '#types/dtos/account/wallet.login.request.dto';
-import { WalletLoginConfigResponseDto } from '#types/dtos/account/wallet.login.config.response.dto';
-import { WalletLoginResponseDto } from '#types/dtos/account/wallet.login.response.dto';
-import {
-  Body,
-  Controller,
-  Get,
-  Post,
-  HttpCode,
-  HttpStatus,
-  Param,
-  Inject,
-  NotFoundException,
-  ForbiddenException,
-} from '@nestjs/common';
+import { Body, Controller, Get, Post, HttpCode, HttpStatus, Param, Inject, NotFoundException } from '@nestjs/common';
 import { ApiBody, ApiOkResponse, ApiCreatedResponse, ApiOperation, ApiTags } from '@nestjs/swagger';
 import { RetireMsaRequestDto, TransactionResponse } from '#types/dtos/account';
 import { AccountIdDto, MsaIdDto } from '#types/dtos/common';
@@ -31,15 +17,6 @@ export class AccountsControllerV1 {
     // eslint-disable-next-line no-empty-function
   ) {}
 
-  @Get('siwf')
-  @HttpCode(HttpStatus.OK)
-  @ApiOperation({ summary: 'Get the Sign In With Frequency configuration' })
-  @ApiOkResponse({ description: 'Returned SIWF Configuration data', type: WalletLoginConfigResponseDto })
-  async getSIWFConfig(): Promise<WalletLoginConfigResponseDto> {
-    this.logger.debug('Received request for Sign In With Frequency Configuration');
-    return this.accountsService.getSIWFConfig();
-  }
-
   @Get(':msaId')
   @HttpCode(HttpStatus.OK)
   @ApiOperation({ summary: 'Fetch an account given an MSA Id' })
@@ -77,18 +54,6 @@ export class AccountsControllerV1 {
     throw new NotFoundException(`Failed to find the account ${accountId}`);
   }
 
-  @Post('siwf')
-  @HttpCode(HttpStatus.CREATED)
-  @ApiOperation({ summary: 'Request to Sign In With Frequency' })
-  @ApiCreatedResponse({ description: 'Signed in successfully', type: WalletLoginResponseDto })
-  async postSignInWithFrequency(@Body() walletLoginRequest: WalletLoginRequestDto): Promise<WalletLoginResponseDto> {
-    if (this.config.isDeployedReadOnly && walletLoginRequest.signUp) {
-      throw new ForbiddenException('New account sign-up unavailable in read-only mode');
-    }
-    this.logger.debug(`Received Sign In With Frequency request: ${JSON.stringify(walletLoginRequest)}`);
-    return this.accountsService.signInWithFrequency(walletLoginRequest);
-  }
-
   @Get('retireMsa/:accountId')
   @HttpCode(HttpStatus.OK)
   @ApiOperation({ summary: 'Get a retireMsa unsigned, encoded extrinsic payload.' })

apps/account-api/src/controllers/v1/accounts-v1.controller.ts

@@ -20,7 +20,7 @@ import {
   BadRequestException,
 } from '@nestjs/common';
 import { ApiOkResponse, ApiOperation, ApiTags } from '@nestjs/swagger';
-import { hasChainSubmissions, isPayloadClaimHandle } from '@projectlibertylabs/siwfv2';
+import { hasChainSubmissions, isPayloadClaimHandle } from '@projectlibertylabs/siwf';
 import { InjectPinoLogger, PinoLogger } from 'nestjs-pino';
 
 // # SIWF Wallet API V2

apps/account-api/src/controllers/v2/accounts-v2.controller.ts

@@ -1,21 +1,12 @@
-import { BadRequestException, Inject, Injectable, UnprocessableEntityException } from '@nestjs/common';
-import { validateSignin, validateSignup } from '@projectlibertylabs/siwfv1';
+import { Inject, Injectable, UnprocessableEntityException } from '@nestjs/common';
 import { BlockchainRpcQueryService } from '#blockchain/blockchain-rpc-query.service';
 import { EnqueueService } from '#account-lib/services/enqueue-request.service';
-import { WalletLoginRequestDto } from '#types/dtos/account/wallet.login.request.dto';
-import { WalletLoginResponseDto } from '#types/dtos/account/wallet.login.response.dto';
 import {
   AccountResponseDto,
   MsaIdResponseDto,
   RetireMsaPayloadResponseDto,
 } from '#types/dtos/account/accounts.response.dto';
-import { WalletLoginConfigResponseDto } from '#types/dtos/account/wallet.login.config.response.dto';
-import {
-  PublishRetireMsaRequestDto,
-  PublishSIWFSignupRequestDto,
-  RetireMsaRequestDto,
-  TransactionResponse,
-} from '#types/dtos/account';
+import { PublishRetireMsaRequestDto, RetireMsaRequestDto, TransactionResponse } from '#types/dtos/account';
 import { TransactionType } from '#types/account-webhook';
 import apiConfig, { IAccountApiConfig } from '#account-api/api.config';
 import blockchainConfig, { IBlockchainConfig } from '#blockchain/blockchain.config';
@@ -59,53 +50,6 @@ export class AccountsService {
     return null;
   }
 
-  async getSIWFConfig(): Promise<WalletLoginConfigResponseDto> {
-    const { siwfNodeRpcUrl, siwfUrl }: IAccountApiConfig = this.apiCOnf;
-    const { providerId } = this.blockchainConf;
-    return {
-      providerId: providerId.toString(),
-      siwfUrl: siwfUrl.toString(),
-      frequencyRpcUrl: siwfNodeRpcUrl?.toString(),
-    };
-  }
-
-  // eslint-disable-next-line class-methods-use-this
-  async signInWithFrequency(request: WalletLoginRequestDto): Promise<WalletLoginResponseDto> {
-    const api = (await this.blockchainService.getApi()) as ApiPromise;
-    const { providerId } = this.blockchainConf;
-    if (request.signUp) {
-      try {
-        const siwfPayload = await validateSignup(api, request.signUp, providerId.toString());
-        // Pass all this data to the transaction publisher queue
-        const referenceId: WalletLoginResponseDto =
-          await this.enqueueService.enqueueRequest<PublishSIWFSignupRequestDto>({
-            ...siwfPayload,
-            type: TransactionType.SIWF_SIGNUP,
-          });
-        return referenceId;
-      } catch (e: any) {
-        this.logger.error(`Failed Signup validation ${e.toString()}`);
-        throw new UnprocessableEntityException('Failed to sign up');
-      }
-    } else if (request.signIn) {
-      try {
-        const parsedSignin = await validateSignin(api, request.signIn, 'localhost');
-        const response: WalletLoginResponseDto = {
-          referenceId: '0',
-          msaId: parsedSignin.msaId,
-          publicKey: parsedSignin.publicKey,
-        };
-        return response;
-      } catch (e) {
-        this.logger.error(`Error during SIWF signin request: ${e}`);
-        const { cause } = e as any;
-        this.logger.error(`cause: ${cause}`);
-        throw new UnprocessableEntityException('Failed to Sign In With Frequency');
-      }
-    }
-    throw new BadRequestException('Invalid Sign In With Frequency Request');
-  }
-
   async getRetireMsaPayload(accountId: string): Promise<RetireMsaPayloadResponseDto | null> {
     try {
       const msaId = await this.getMsaIdForAccountId(accountId);

apps/account-api/src/services/accounts.service.ts

@@ -1,4 +1,4 @@
-import type { SiwfResponse } from '@projectlibertylabs/siwfv2';
+import type { SiwfResponse } from '@projectlibertylabs/siwf';
 
 // Mock Server Authorization Codes:
 // validEthereumSiwfAddDelegationResponsePayload

apps/account-api/src/services/siwfV2-ethereum.mock.spec.ts

@@ -1,4 +1,4 @@
-import type { SiwfResponse } from '@projectlibertylabs/siwfv2';
+import type { SiwfResponse } from '@projectlibertylabs/siwf';
 import { createServer, Server, IncomingMessage, ServerResponse } from 'node:http';
 import { validEthereumSiwfLoginResponsePayload } from '#account-api/services/siwfV2-ethereum.mock.spec';
 import { URL } from 'node:url';

apps/account-api/src/services/siwfV2.mock.spec.ts

@@ -1,7 +1,7 @@
 import { expect, it, jest } from '@jest/globals';
 import { Test, TestingModule } from '@nestjs/testing';
 import { BadRequestException } from '@nestjs/common';
-import { CurveType, decodeSignedRequest } from '@projectlibertylabs/siwfv2';
+import { CurveType, decodeSignedRequest } from '@projectlibertylabs/siwf';
 import base64url from 'base64url';
 import { SiwfV2Service } from './siwfV2.service';
 import { WalletV2RedirectResponseDto } from '#types/dtos/account/wallet.v2.redirect.response.dto';

apps/account-api/src/services/siwfV2.service.spec.ts

@@ -17,7 +17,7 @@ import {
   isPayloadAddProvider,
   SiwfResponsePayload,
   isCredentialRecoverySecret,
-} from '@projectlibertylabs/siwfv2';
+} from '@projectlibertylabs/siwf';
 import apiConfig, { IAccountApiConfig } from '#account-api/api.config';
 import blockchainConfig, { IBlockchainConfig } from '#blockchain/blockchain.config';
 import { BlockchainRpcQueryService } from '#blockchain/blockchain-rpc-query.service';

apps/account-api/src/services/siwfV2.service.ts

@@ -1,3 +1,4 @@
+import { RetireMsaPayloadResponseDto, RetireMsaRequestDto } from '#types/dtos/account';
 import { HttpStatus, ValidationPipe, VersioningType } from '@nestjs/common';
 import { Test, TestingModule } from '@nestjs/testing';
 import { EventEmitter2 } from '@nestjs/event-emitter';
@@ -9,7 +10,6 @@ import { setupProviderAndUsers } from './e2e-setup.mock.spec';
 import { u8aToHex } from '@polkadot/util';
 import { cryptoWaitReady } from '@polkadot/util-crypto';
 import { CacheMonitorService } from '#cache/cache-monitor.service';
-import { WalletLoginRequestDto, RetireMsaPayloadResponseDto, RetireMsaRequestDto } from '#types/dtos/account';
 import apiConfig, { IAccountApiConfig } from '#account-api/api.config';
 import { TimeoutInterceptor } from '#utils/interceptors/timeout.interceptor';
 import { NestExpressApplication } from '@nestjs/platform-express';
@@ -139,50 +139,6 @@ describe('Account Controller', () => {
     });
   });
 
-  describe('(POST) /accounts/siwf', () => {
-    it('Sign Up With Frequency request should work', async () => {
-      const siwfRequest: WalletLoginRequestDto = {
-        signIn: {},
-        signUp: {
-          extrinsics: [
-            {
-              pallet: 'msa',
-              extrinsicName: 'createSponsoredAccountWithDelegation',
-              encodedExtrinsic:
-                '0xed01043c01b01b4dcafc8a8e73bff98e7558249f53cd0e0e64fa6b8f0159f0913d4874d9360176644186458bad3b00bbd0ac21e6c9bd5a8bed9ced7a772d11a9aac025b47f6559468808e272696f596a02af230951861027c0dc30f7163ecf316838a0723483010000000000000014000000000000000000004d000000',
-            },
-            {
-              pallet: 'handles',
-              extrinsicName: 'claimHandle',
-              encodedExtrinsic:
-                '0xb901044200b01b4dcafc8a8e73bff98e7558249f53cd0e0e64fa6b8f0159f0913d4874d93601225508ae2da9804c60660a150277eb32b2a0f6b9c8f6e07dd6cad799cb31ae1dfb43896f488e9c0b7ec8b530d930b3f9b690683f2765d5def3fee3fc6540d58714656e6464794d000000',
-            },
-          ],
-        },
-      };
-
-      await request(httpServer).post(`/v1/accounts/siwf`).send(siwfRequest).expect(201);
-    });
-
-    it('Sign In With Frequency request should work', (done) => {
-      const siwfRequest: WalletLoginRequestDto = {
-        signIn: {
-          siwsPayload: {
-            message:
-              'localhost wants you to sign in with your Frequency account:\n5Fghb4Wt3sg9cF6Q2Qucp5jXV5pL2U9uaYXwR9R8W8SYe9np\n\nThe domain localhost wants you to sign in with your Frequency account via localhost\n\nURI: http://localhost:5173/signin/confirm\nNonce: N6rLwqyz34oUxJEXJ\nIssued At: 2024-03-05T23:18:03.041Z\nExpiration Time: 2024-03-05T23:23:03.041Z',
-            signature:
-              '0x38faa2fc6f59bef8ffccfc929fb966e1d53ba45e3af7a029ea1d636eaddcbe78a4be0f89eaf7ff7bbaef20a070ad65f9d0f876889686687ef623214fddddb18b',
-          },
-        },
-        signUp: {
-          extrinsics: [],
-        },
-      };
-
-      request(httpServer).post(`/v1/accounts/siwf`).send(siwfRequest).expect(201).end(done);
-    });
-  });
-
   describe('retireMsa', () => {
     it('(GET) /v1/accounts/retireMsa/:accountId get payload for retireMsa, given a valid accountId', async () => {
       const accountId = users[0].keypair.address;

apps/account-api/test/accounts.controller.e2e-spec.ts

@@ -2,7 +2,7 @@ import { HttpStatus, ValidationPipe, VersioningType } from '@nestjs/common';
 import { Test, TestingModule } from '@nestjs/testing';
 import { EventEmitter2 } from '@nestjs/event-emitter';
 import { cryptoWaitReady } from '@polkadot/util-crypto';
-import { decodeSignedRequest } from '@projectlibertylabs/siwfv2';
+import { decodeSignedRequest } from '@projectlibertylabs/siwf';
 import type { Server } from 'node:http';
 import base64url from 'base64url';
 import request from 'supertest';