-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Description
The new /v3/content/batchAnnouncement does not report errors consistently or in some cases at all.
Expected Results
Unless the payload is completely malformed, the endpoint should always respond with HTTP 202, and the response body should contain the disposition of every file in the batch announcement request.
Actual Results
The app does actually respond with HTTP 202 in most cases correctly; however:
- In some cases, the app throws a
BadRequestException, which is not actually handled but causes problems in the log - In some cases, excess/errored files are not included in the response
Notes:
- Busboy event handlers should not throw HTTP exceptions, as they are not actually bubbled out to the response. Normal error logging should be preferred.
- All errors produced when processing a valid request object should be returned in the body of the response
- All valid parts of a request should be processed, and disposition (success or error) returned
- Mostly, the only scenarios that should cause other than a 202 response are those that involve a completely incorrect payload (ZERO valid request parts), or in the case where ALL files in the request failed to upload (500)
- If the response consists of mixed successes/failures, the response status should be HTTP 207
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working