fix passing next cursor for getAllListings/getAllOffers (#1302)

Author: ryanio

package.json

@@ -1,6 +1,6 @@
 {
   "name": "opensea-js",
-  "version": "6.1.14",
+  "version": "6.1.15",
   "description": "JavaScript SDK for the OpenSea marketplace helps developers build new experiences using NFTs and our marketplace data!",
   "license": "MIT",
   "author": "OpenSea Developers",

src/api/api.ts

@@ -199,10 +199,10 @@ export class OpenSeaAPI {
   ): Promise<GetOffersResponse> {
     const response = await this.get<GetOffersResponse>(
       getAllOffersAPIPath(collectionSlug),
-      serializeOrdersQueryOptions({
+      {
         limit,
         next,
-      }),
+      },
     );
     return response;
   }
@@ -221,10 +221,10 @@ export class OpenSeaAPI {
   ): Promise<GetListingsResponse> {
     const response = await this.get<GetListingsResponse>(
       getAllListingsAPIPath(collectionSlug),
-      serializeOrdersQueryOptions({
+      {
         limit,
         next,
-      }),
+      },
     );
     return response;
   }

src/api/types.ts

@@ -156,19 +156,27 @@ export type GetOrdersResponse = QueryCursors & {
   orders: OrderV2[];
 };
 
+/**
+ * Base query cursors response from OpenSea API.
+ * @category API Response Types
+ */
+export type QueryCursorsV2 = {
+  next?: string;
+};
+
 /**
  * Response from OpenSea API for fetching offers.
  * @category API Response Types
  */
-export type GetOffersResponse = QueryCursors & {
+export type GetOffersResponse = QueryCursorsV2 & {
   offers: Offer[];
 };
 
 /**
  * Response from OpenSea API for fetching listings.
  * @category API Response Types
  */
-export type GetListingsResponse = QueryCursors & {
+export type GetListingsResponse = QueryCursorsV2 & {
   listings: Listing[];
 };
 

test/integration/getListingsAndOffers.spec.ts

@@ -37,6 +37,25 @@ suite("SDK: getAllListings", () => {
       response.listings[0].protocol_data,
       "Protocol data should not be null",
     );
+    assert(response.next, "Cursor for next page should not be null");
+
+    // Should get the next page of listings
+    const responsePage2 = await sdk.api.getAllListings(
+      slug,
+      undefined,
+      response.next,
+    );
+    assert(responsePage2, "Response should not be null");
+    assert.notDeepEqual(
+      response.listings,
+      responsePage2.listings,
+      "Response of second page should not equal the response of first page",
+    );
+    assert.notEqual(
+      response.next,
+      responsePage2.next,
+      "Next cursor should change",
+    );
   });
 });