Bug in filtering based on "unvalidated" in gallery

[jonfroehlich]

There are plenty of unvalidated "Obstacles" in Walla Walla. I filter down to that category and get no results:

Then I click the "unsure" button as well and suddenly lots show but those labels do not look like they have validations and so should have shown up before when I had just clicked "unvalidated"

[misaugstad]

The labels that you're seeing when you look at "Unsure" do have "Unsure" validations, but we don't show an icon for that right now. I just queried for Obstacle labels in Walla Walla that have no validations, and found none in the db.

select count(*)
from label
left join label_validation using (label_id)
inner join gsv_data on label.gsv_panorama_id = gsv_data.gsv_panorama_id
where label_type_id = 3
    and expired = false
    and label_validation.label_validation_id is null;

And I looked at one of the labels with no thumbs up/down from Gallery, and looked at it here and it does have Unsure validations.

With Manjiri's redesigned popup menu you'll at least be able to see the unsure votes in Gallery (on the expanded view) soon.

[jonfroehlich]

Hmm, this suggests that we should have the unsure icon even on the minimal card view. Tagging @Manjiridesigns explicitly now that she's on GitHub!

[misaugstad]

I'm not convinced that it's worth crowding the smaller cards to avoid this type of confusion but I'm open to it!

[Manjiridesigns]

This is what it would look like with the unsure icon.

We can comfortably fit 2 tags of average length with the unsure icon.

[jonfroehlich]

Nice. Thanks. Hmm, seeing them here though does feel busy (as @misaugstad predicted).

Also, I have to admit, I do not like the new thumb design with the triangle thumbs--reminds me of a wicket witch!

Can we just use the old thumbs? I think your new unsure icon still works with the old ones.