[ Fix ] Update command creates hooks as non-executable (#82)

* remove deprecated binary reference

* update command should ensure hooks are executable

* lint

* update php version to 8.4 in CI

* increase memory limit in stan script

* update legacy GH actions set-output

* revert to legacy set-output in test.yml

Author: ProjektGopher

.github/workflows/larastan.yml

@@ -8,7 +8,7 @@ jobs:
         operating-system:
           - ubuntu-latest
         php-version:
-          - "8.2"
+          - "8.4"
     name: php ${{ matrix.php-version }} on ${{ matrix.operating-system }}
     runs-on: ${{ matrix.operating-system }}
     steps:
@@ -22,7 +22,7 @@ jobs:
           coverage: none
       - name: Get composer cache directory
         id: composer-cache
-        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
       - name: Setup composer cache
         uses: actions/cache@v4
         with:

.github/workflows/pint.yml

@@ -11,7 +11,7 @@ jobs:
         operating-system:
           - ubuntu-latest
         php-version:
-          - "8.2"
+          - "8.4"
     name: php ${{ matrix.php-version }} on ${{ matrix.operating-system }}
     runs-on: ${{ matrix.operating-system }}
     steps:
@@ -20,12 +20,12 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: "8.2"
+          php-version: "8.4"
           extensions: bcmath, ctype, fileinfo, json, mbstring, openssl, pdo, tokenizer, xml
           coverage: none
       - name: Get composer cache directory
         id: composer-cache
-        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
       - name: Setup composer cache
         uses: actions/cache@v4
         with:

.github/workflows/test.yml

@@ -13,6 +13,7 @@ jobs:
           - "8.1"
           - "8.2"
           - "8.3"
+          - "8.4"
     name: php ${{ matrix.php-version }} on ${{ matrix.operating-system }}
     runs-on: ${{ matrix.operating-system }}
     steps:

.github/workflows/types.yml

@@ -8,7 +8,7 @@ jobs:
         operating-system:
           - ubuntu-latest
         php-version:
-          - "8.2"
+          - "8.4"
     name: php ${{ matrix.php-version }} on ${{ matrix.operating-system }}
     runs-on: ${{ matrix.operating-system }}
     steps:
@@ -22,7 +22,7 @@ jobs:
           coverage: none
       - name: Get composer cache directory
         id: composer-cache
-        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
       - name: Setup composer cache
         uses: actions/cache@v4
         with:

app/Commands/Install.php

@@ -74,7 +74,6 @@ public function handle(): int
                 $this->info('Verifying hooks are executable...');
             }
             exec('chmod +x '.Platform::cwd('.git/hooks').'/*');
-            exec('chmod +x '.Whisky::base_path('bin/run-hook'));
         }
 
         $this->info('Git hooks installed successfully.');

app/Commands/Update.php

@@ -4,6 +4,7 @@
 
 use LaravelZero\Framework\Commands\Command;
 use ProjektGopher\Whisky\Hook;
+use ProjektGopher\Whisky\Platform;
 
 /**
  * TODO: This has a lot of duplication wrt Commands\Uninstall and Commands\Install.
@@ -14,6 +15,12 @@ class Update extends Command
 
     protected $description = 'Update git hooks';
 
+    public function __construct(
+        public Platform $platform,
+    ) {
+        parent::__construct();
+    }
+
     public function handle(): int
     {
         Hook::all(Hook::FROM_GIT)->each(function (Hook $hook): void {
@@ -42,7 +49,14 @@ public function handle(): int
             }
         });
 
-        $this->line('done.');
+        if ($this->platform->isNotWindows()) {
+            if ($this->option('verbose')) {
+                $this->info('Verifying hooks are executable...');
+            }
+            exec('chmod +x '.Platform::cwd('.git/hooks').'/*');
+        }
+
+        $this->line('Git hooks updated successfully.');
 
         return Command::SUCCESS;
     }

app/Hook.php

@@ -148,9 +148,9 @@ public function getSnippets(): Collection
         ]);
     }
 
-    ////////////////////////////////////////
-    ////         Static methods         ////
-    ////////////////////////////////////////
+    // //////////////////////////////////////
+    // //         Static methods         ////
+    // //////////////////////////////////////
 
     /**
      * Static Constructor.

composer.json

@@ -63,7 +63,7 @@
             "vendor/bin/pint"
         ],
         "stan": [
-            "vendor/bin/phpstan analyse"
+            "vendor/bin/phpstan analyse --memory-limit=1G"
         ],
         "test": [
             "@php whisky test"