Skip to content

Commit ea7c01b

Browse files
Copilotgfauredev
andcommitted
fix: guard tests with BUILD_TESTING, remove doctest from cross-build deps
Co-authored-by: gfauredev <19304085+gfauredev@users.noreply.github.com>
1 parent ddc9ee7 commit ea7c01b

4 files changed

Lines changed: 17 additions & 14 deletions

File tree

CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ add_custom_target(
5858
DEPENDS merge_coverage_data
5959
COMMENT "Rapport de couverture HTML généré: ${CMAKE_BINARY_DIR}/coverage")
6060
add_dependencies(run main)
61-
add_dependencies(tests LoggerTest)
62-
add_dependencies(tests integrationTest)
61+
if(BUILD_TESTING)
62+
add_dependencies(tests LoggerTest)
63+
add_dependencies(tests integrationTest)
64+
endif()
6365
add_dependencies(coverage merge_coverage_data)

flake.nix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
clang-tools # Clang CLIs, including LSP
6666
cmake-format # CMake formatter
6767
cmake-language-server # Cmake LSP
68+
doctest # Testing framework (for local -DBUILD_TESTING=ON builds)
6869
doxygen # Documentation generator
6970
lldb # Clang debug adapter
7071
]

test/CMakeLists.txt

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
1-
find_package(doctest REQUIRED)
2-
include(CTest)
1+
if(BUILD_TESTING)
2+
find_package(doctest REQUIRED)
3+
include(CTest)
34

4-
add_executable(LoggerTest LoggerTest.cpp)
5-
target_include_directories(LoggerTest PRIVATE ${CMAKE_SOURCE_DIR}/include)
6-
target_link_libraries(LoggerTest PRIVATE doctest::doctest)
7-
add_test(NAME LoggerTest COMMAND LoggerTest)
5+
add_executable(LoggerTest LoggerTest.cpp)
6+
target_include_directories(LoggerTest PRIVATE ${CMAKE_SOURCE_DIR}/include)
7+
target_link_libraries(LoggerTest PRIVATE doctest::doctest)
8+
add_test(NAME LoggerTest COMMAND LoggerTest)
89

9-
add_executable(integrationTest integrationTest.cpp)
10-
target_include_directories(integrationTest PRIVATE ${CMAKE_SOURCE_DIR}/include)
11-
target_link_libraries(integrationTest PRIVATE doctest::doctest)
12-
add_test(NAME integrationTest COMMAND integrationTest)
10+
add_executable(integrationTest integrationTest.cpp)
11+
target_include_directories(integrationTest PRIVATE ${CMAKE_SOURCE_DIR}/include)
12+
target_link_libraries(integrationTest PRIVATE doctest::doctest)
13+
add_test(NAME integrationTest COMMAND integrationTest)
14+
endif()

ui.nix

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
cmake,
33
clang,
4-
doctest,
54
engine,
65
glfw,
76
llvm,
@@ -32,7 +31,6 @@ stdenv.mkDerivation {
3231
pkg-config # Build tool
3332
];
3433
buildInputs = [
35-
doctest # Testing framework
3634
engine # SmartPianoEngine
3735
glfw # Raylib dependency
3836
libGL # GPU library

0 commit comments

Comments
 (0)