Add test to fix the model name is empty error

Author: tintinrevient

src/pg2_benchmark/model_card.py

@@ -1,7 +1,8 @@
-import frontmatter
-from pydantic import BaseModel, Field, ConfigDict
 from pathlib import Path
-from typing import Self, Any
+from typing import Any, Self
+
+import frontmatter
+from pydantic import BaseModel, ConfigDict, Field
 
 
 class ModelCard(BaseModel):
@@ -20,7 +21,7 @@ class ModelCard(BaseModel):
 
     model_config = ConfigDict(extra="allow")
 
-    name: str = ""
+    name: str
     hyper_params: dict[str, Any] = Field(default_factory=dict)
 
     @classmethod

tests/test_validate.py

@@ -0,0 +1,103 @@
+from pathlib import Path
+from unittest.mock import patch
+
+import pytest
+from typer.testing import CliRunner
+
+from pg2_benchmark.cli.validate import ModelPath, validate_app
+
+
+@pytest.fixture
+def runner():
+    """Test runner for CLI commands."""
+    return CliRunner()
+
+
+@pytest.fixture
+def valid_model_card_content() -> str:
+    """Valid model card content for testing."""
+    return """---
+name: "test_model"
+hyper_params:
+    learning_rate: 0.001
+    batch_size: 32
+---
+
+# Test Model
+This is a test model card.
+"""
+
+
+@pytest.fixture
+def invalid_model_card_content() -> str:
+    """Invalid model card content for testing."""
+    return """---
+invalid_yaml: [
+---
+
+# Invalid Model Card
+"""
+
+
+def test_model_card_validation_success(
+    tmp_path: Path, valid_model_card_content: str, runner: CliRunner
+):
+    """Test successful model card validation."""
+    model_name = "test_model"
+    model_dir = tmp_path / "models" / model_name
+    model_dir.mkdir(parents=True)
+
+    model_card_file = model_dir / "README.md"
+    model_card_file.write_text(valid_model_card_content)
+
+    with patch.object(ModelPath, "ROOT_PATH", tmp_path / "models"):
+        result = runner.invoke(validate_app, [model_name])
+
+    assert result.exit_code == 0
+    assert "✅ Loaded test_model" in result.stdout
+    assert "learning_rate" in result.stdout and "batch_size" in result.stdout
+
+
+def test_model_card_validation_missing_file(tmp_path: Path, runner: CliRunner):
+    """Test validation when model card file doesn't exist."""
+    model_name = "nonexistent_model"
+
+    with patch.object(ModelPath, "ROOT_PATH", tmp_path / "models"):
+        result = runner.invoke(validate_app, [model_name])
+
+    assert result.exit_code == 1
+    assert "❌ Model nonexistent_model does not have a model card" in result.stdout
+
+
+def test_model_card_validation_invalid_content(
+    tmp_path: Path, invalid_model_card_content: str, runner: CliRunner
+):
+    """Test validation with invalid model card content."""
+    model_name = "invalid_model"
+    model_dir = tmp_path / "models" / model_name
+    model_dir.mkdir(parents=True)
+
+    model_card_file = model_dir / "README.md"
+    model_card_file.write_text(invalid_model_card_content)
+
+    with patch.object(ModelPath, "ROOT_PATH", tmp_path / "models"):
+        result = runner.invoke(validate_app, [model_name])
+
+    assert result.exit_code == 1
+    assert "❌ Error loading model card" in result.stdout
+
+
+def test_model_card_validation_empty_file(tmp_path: Path, runner: CliRunner):
+    """Test validation with empty model card file."""
+    model_name = "empty_model"
+    model_dir = tmp_path / "models" / model_name
+    model_dir.mkdir(parents=True)
+
+    model_card_file = model_dir / "README.md"
+    model_card_file.write_text("")
+
+    with patch.object(ModelPath, "ROOT_PATH", tmp_path / "models"):
+        result = runner.invoke(validate_app, [model_name])
+
+    assert result.exit_code == 1
+    assert "❌ Error loading model card" in result.stdout