Refresh core feature flags with periodic update manager

Author: mateusz-markowicz

app/src/main/java/com/protonvpn/android/ProtonApplication.java

@@ -29,6 +29,7 @@
 
 import com.evernote.android.state.StateSaver;
 import com.protonvpn.android.api.DohEnabled;
+import com.protonvpn.android.appconfig.CoreFeatureFlagUpdater;
 import com.protonvpn.android.appconfig.periodicupdates.PeriodicUpdateManager;
 import com.protonvpn.android.auth.usecase.CloseSessionOnForceLogout;
 import com.protonvpn.android.components.RestartHandler;
@@ -79,7 +80,6 @@
 import kotlinx.coroutines.ExecutorsKt;
 import me.proton.core.accountmanager.data.AccountStateHandler;
 import me.proton.core.eventmanager.data.CoreEventManagerStarter;
-import me.proton.core.featureflag.data.FeatureFlagRefreshStarter;
 import me.proton.core.humanverification.presentation.HumanVerificationStateHandler;
 import me.proton.core.util.kotlin.CoreLogger;
 
@@ -100,9 +100,9 @@ interface DependencyEntryPoints {
         CertificateRepository getCertificateRepository();
         CloseSessionOnForceLogout getCloseSessionOnForceLogout();
         CoreEventManagerStarter getCoreEventManagerStarter();
+        CoreFeatureFlagUpdater getCoreFeatureFlagRefresher();
         CurrentStateLogger getCurrentStateLogger();
         DohEnabled.Provider getDohEnabledProvider();
-        FeatureFlagRefreshStarter getFeatureFlagRefreshStarter();
         HumanVerificationStateHandler getHumanVerificationStateHandler();
         LogcatLogCapture getLogcatLogCapture();
         MaintenanceTracker getMaintenanceTracker();
@@ -167,8 +167,8 @@ public void initDependencies() {
         dependencies.getAccountStateHandler().start();
         dependencies.getCertificateRepository();
         dependencies.getCloseSessionOnForceLogout();
+        dependencies.getCoreFeatureFlagRefresher().start();
         dependencies.getDohEnabledProvider();
-        dependencies.getFeatureFlagRefreshStarter().start();
         dependencies.getHumanVerificationStateHandler().observe();
         dependencies.getMaintenanceTracker();
         dependencies.getNotificationPermissionManager();

app/src/main/java/com/protonvpn/android/appconfig/CoreFeatureFlagUpdater.kt

@@ -0,0 +1,78 @@
+/*
+ * Copyright (c) 2023 Proton AG
+ *
+ * This file is part of ProtonVPN.
+ *
+ * ProtonVPN is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * ProtonVPN is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with ProtonVPN.  If not, see <https://www.gnu.org/licenses/>.
+ */
+package com.protonvpn.android.appconfig
+
+import com.protonvpn.android.appconfig.periodicupdates.IsInForeground
+import com.protonvpn.android.appconfig.periodicupdates.PeriodicActionResult
+import com.protonvpn.android.appconfig.periodicupdates.PeriodicUpdateManager
+import com.protonvpn.android.appconfig.periodicupdates.PeriodicUpdateSpec
+import com.protonvpn.android.appconfig.periodicupdates.registerAction
+import com.protonvpn.android.auth.usecase.CurrentUser
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.flow.distinctUntilChangedBy
+import kotlinx.coroutines.flow.launchIn
+import kotlinx.coroutines.flow.map
+import kotlinx.coroutines.flow.onEach
+import me.proton.core.domain.entity.UserId
+import me.proton.core.featureflag.domain.ExperimentalProtonFeatureFlag
+import me.proton.core.featureflag.domain.FeatureFlagManager
+import java.util.concurrent.TimeUnit
+import javax.inject.Inject
+import javax.inject.Singleton
+
+@OptIn(ExperimentalProtonFeatureFlag::class)
+@Singleton
+class CoreFeatureFlagUpdater @Inject constructor(
+    private val scope: CoroutineScope,
+    private val currentUser: CurrentUser,
+    private val featureFlagManager: FeatureFlagManager,
+    private val periodicUpdateManager: PeriodicUpdateManager,
+    @IsInForeground inForeground: Flow<Boolean>,
+) {
+    private val coreFeatureFlagsUpdate = periodicUpdateManager.registerAction(
+        "core_feature_flags",
+        ::refreshInternal,
+        { currentUser.user()?.userId },
+        PeriodicUpdateSpec(UPDATE_DELAY_FOREGROUND, setOf(inForeground)),
+        PeriodicUpdateSpec(UPDATE_DELAY_BACKGROUND, setOf()),
+    )
+
+    fun start() {
+        // No persistency so far for feature flags, so we need to always force refresh on start.
+        // We also need to refresh each time user changes
+        currentUser.vpnUserFlow
+            .distinctUntilChangedBy { Pair(it?.userId, it?.planName) }
+            .map { it?.userId }
+            .onEach {
+                periodicUpdateManager.executeNow(coreFeatureFlagsUpdate, it)
+            }.launchIn(scope)
+    }
+
+    private fun refreshInternal(userId: UserId?) : PeriodicActionResult<Unit> {
+        featureFlagManager.refreshAll(userId)
+        // No way to check if the refresh succeeded, worst case it'll try again later
+        return PeriodicActionResult(Unit, isSuccess = true)
+    }
+
+    companion object {
+        private val UPDATE_DELAY_FOREGROUND = TimeUnit.HOURS.toMillis(2)
+        private val UPDATE_DELAY_BACKGROUND = TimeUnit.HOURS.toMillis(12)
+    }
+}