refactor(metagame): drop redundant extension config storage

The extension contract is the sole source of truth for its own config —
duplicating it on the host-side component was convenience state that
also cost variable-length Vec<felt252> storage proportional to config
size (substantial for prizes with many positions). The component only
needs the extension address to dispatch claim/pay calls, which doubles
as the "is this an extension?" flag.

Removed (now Span<felt252> config is forward-only, no on-chain copy):
- EntryFee_extension_config / Prize_extension_config storage maps
- get/set/push extension_config Store trait methods
- read_extension_config / write_extension_config helpers in both
  *_store.cairo bridge layers and the component public surface
- _set_extension's write_extension_config call

What stays:
- *_extension_address storage (required for dispatch + "is registered?")
- get_extension_address public accessor
- IEntryFeeExtension.set_entry_fee_config / IPrizeExtension.add_prize
  dispatch — config is forwarded to the extension, which stores what it
  cares about

Indexer impact: hosts emitting their original create/add events with
the full ExtensionConfig payload (e.g. budokan's TournamentCreated
carries Option<EntryFeeKind> which includes the config) are unaffected
— indexers should source config from the host's event stream rather
than from on-chain component state. For prize extensions with no
analogous host event, indexers should call the extension contract
directly.

Test impact: removed config-storage-specific tests; address-storage and
dispatch tests stay. 430 metagame tests pass (was 440, -10 dropped
storage tests).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: starknetdev

packages/metagame/src/entry_fee/entry_fee_component.cairo

@@ -23,8 +23,7 @@ pub mod EntryFeeComponent {
     use openzeppelin_introspection::src5::SRC5Component;
     use openzeppelin_introspection::src5::SRC5Component::InternalTrait as SRC5InternalTrait;
     use starknet::storage::{
-        Map, MutableVecTrait, StoragePathEntry, StoragePointerReadAccess, StoragePointerWriteAccess,
-        Vec, VecTrait,
+        Map, StoragePathEntry, StoragePointerReadAccess, StoragePointerWriteAccess,
     };
     use starknet::{ContractAddress, get_caller_address, get_contract_address};
     use crate::entry_fee::entry_fee_store::{EntryFeeStoreImpl, EntryFeeStoreTrait};
@@ -62,10 +61,12 @@ pub mod EntryFeeComponent {
         EntryFee_distribution: Map<u64, PackedDistribution>,
         /// Refund claimed: (context_id, token_id) -> claimed
         EntryFee_refund_claimed: Map<(u64, felt252), bool>,
-        /// Extension address for extension-enhanced entry fees
+        /// Extension address for extension-enhanced entry fees. Doubles as
+        /// the "is this context's fee an extension?" flag: zero means no
+        /// extension is configured. The extension contract owns the
+        /// authoritative config — this component only stores the address
+        /// it needs for dispatch.
         EntryFee_extension_address: Map<u64, ContractAddress>,
-        /// Extension config data (stored as Vec)
-        EntryFee_extension_config: Map<u64, Vec<felt252>>,
     }
 
     #[event]
@@ -151,22 +152,6 @@ pub mod EntryFeeComponent {
             self.EntryFee_extension_address.entry(context_id).write(address);
         }
 
-        fn get_extension_config_len(self: @ComponentState<TContractState>, context_id: u64) -> u64 {
-            self.EntryFee_extension_config.entry(context_id).len()
-        }
-
-        fn get_extension_config_at(
-            self: @ComponentState<TContractState>, context_id: u64, index: u64,
-        ) -> felt252 {
-            self.EntryFee_extension_config.entry(context_id).at(index).read()
-        }
-
-        fn push_extension_config(
-            ref self: ComponentState<TContractState>, context_id: u64, value: felt252,
-        ) {
-            self.EntryFee_extension_config.entry(context_id).push(value);
-        }
-
         fn get_distribution_shares_packed(
             self: @ComponentState<TContractState>, context_id: u64, slot: u8,
         ) -> CustomShares {
@@ -298,12 +283,16 @@ pub mod EntryFeeComponent {
             EntryFeeStoreTrait::set_entry_fee_config(ref self, context_id, config);
         }
 
-        /// Internal: store extension config and notify extension contract
+        /// Internal: persist the extension address and forward the config
+        /// to the extension contract. The config blob is NOT persisted here
+        /// — the extension is the sole source of truth for its own config,
+        /// and indexers wanting to recover it should read the original
+        /// extension call (e.g. via the host's `TournamentCreated`-style
+        /// event) or query the extension's own view methods.
         fn _set_extension(
             ref self: ComponentState<TContractState>, context_id: u64, ext: ExtensionConfig,
         ) {
             EntryFeeStoreTrait::store_extension_address(ref self, context_id, ext.address);
-            EntryFeeStoreTrait::write_extension_config(ref self, context_id, ext.config);
 
             let dispatcher = IEntryFeeExtensionDispatcher { contract_address: ext.address };
             dispatcher.set_entry_fee_config(context_id, ext.config);
@@ -392,21 +381,7 @@ pub mod EntryFeeComponent {
 
         // --- Extension helpers ---
 
-        /// Read extension config for a context
-        fn read_extension_config(
-            self: @ComponentState<TContractState>, context_id: u64,
-        ) -> Span<felt252> {
-            EntryFeeStoreTrait::read_extension_config(self, context_id)
-        }
-
-        /// Write extension config for a context
-        fn write_extension_config(
-            ref self: ComponentState<TContractState>, context_id: u64, config: Span<felt252>,
-        ) {
-            EntryFeeStoreTrait::write_extension_config(ref self, context_id, config);
-        }
-
-        /// Get extension address for a context
+        /// Get extension address for a context (zero = no extension configured).
         fn get_extension_address(
             self: @ComponentState<TContractState>, context_id: u64,
         ) -> ContractAddress {

packages/metagame/src/entry_fee/entry_fee_store.cairo

@@ -35,10 +35,6 @@ pub trait EntryFeeStoreTrait<T> {
     fn is_claimed(self: @T, context_id: u64, claim_type: EntryFeeClaimType) -> bool;
     /// Mark a claim as completed.
     fn set_claimed(ref self: T, context_id: u64, claim_type: EntryFeeClaimType);
-    /// Read extension config for a context.
-    fn read_extension_config(self: @T, context_id: u64) -> Span<felt252>;
-    /// Write extension config for a context.
-    fn write_extension_config(ref self: T, context_id: u64, config: Span<felt252>);
     /// Store extension address.
     fn store_extension_address(ref self: T, context_id: u64, address: ContractAddress);
     /// Get extension address.
@@ -298,31 +294,6 @@ pub impl EntryFeeStoreImpl<T, +Store<T>, +Drop<T>> of EntryFeeStoreTrait<T> {
         }
     }
 
-    fn read_extension_config(self: @T, context_id: u64) -> Span<felt252> {
-        let len = self.get_extension_config_len(context_id);
-        let mut arr = ArrayTrait::new();
-        let mut i: u64 = 0;
-        loop {
-            if i >= len {
-                break;
-            }
-            arr.append(self.get_extension_config_at(context_id, i));
-            i += 1;
-        }
-        arr.span()
-    }
-
-    fn write_extension_config(ref self: T, context_id: u64, config: Span<felt252>) {
-        let mut i: u32 = 0;
-        loop {
-            if i >= config.len() {
-                break;
-            }
-            self.push_extension_config(context_id, *config.at(i));
-            i += 1;
-        };
-    }
-
     fn store_extension_address(ref self: T, context_id: u64, address: ContractAddress) {
         self.set_extension_address(context_id, address);
     }

packages/metagame/src/entry_fee/store.cairo

@@ -22,9 +22,6 @@ pub trait Store<T> {
     fn set_refund_claimed(ref self: T, context_id: u64, token_id: felt252, claimed: bool);
     fn get_extension_address(self: @T, context_id: u64) -> ContractAddress;
     fn set_extension_address(ref self: T, context_id: u64, address: ContractAddress);
-    fn get_extension_config_len(self: @T, context_id: u64) -> u64;
-    fn get_extension_config_at(self: @T, context_id: u64, index: u64) -> felt252;
-    fn push_extension_config(ref self: T, context_id: u64, value: felt252);
     /// Packed custom distribution shares for slot `slot` (15 `u16` per slot).
     /// The number of shares is sourced from `get_distribution().positions` —
     /// no separate count is stored here.

packages/metagame/src/entry_fee/tests/mocks/entry_fee_mock.cairo

@@ -56,16 +56,6 @@ pub mod EntryFeeMock {
         self.entry_fee.set_claimed(context_id, claim_type);
     }
 
-    #[external(v0)]
-    fn read_extension_config(self: @ContractState, context_id: u64) -> Span<felt252> {
-        self.entry_fee.read_extension_config(context_id)
-    }
-
-    #[external(v0)]
-    fn write_extension_config(ref self: ContractState, context_id: u64, config: Span<felt252>) {
-        self.entry_fee.write_extension_config(context_id, config);
-    }
-
     #[external(v0)]
     fn get_extension_address(self: @ContractState, context_id: u64) -> ContractAddress {
         self.entry_fee.get_extension_address(context_id)

packages/metagame/src/entry_fee/tests/test_entry_fee_store.cairo

@@ -27,8 +27,6 @@ trait IEntryFeeMockFull<TContractState> {
     fn is_claimed(self: @TContractState, context_id: u64, claim_type: EntryFeeClaimType) -> bool;
     fn set_claimed(ref self: TContractState, context_id: u64, claim_type: EntryFeeClaimType);
     // Extension functions
-    fn read_extension_config(self: @TContractState, context_id: u64) -> Span<felt252>;
-    fn write_extension_config(ref self: TContractState, context_id: u64, config: Span<felt252>);
     fn get_extension_address(self: @TContractState, context_id: u64) -> ContractAddress;
     fn claim_entry_fee_extension(
         ref self: TContractState, context_id: u64, claim_params: Span<felt252>,
@@ -540,13 +538,15 @@ fn test_additional_share_claim_across_slots() {
 
 // ============================================================================
 // 7. Extension storage via set_entry_fee(Extension) with mock_call
-//    This exercises: _set_extension -> store_extension_address,
-//    write_extension_config, and the IEntryFeeExtension dispatch.
+//    Exercises _set_extension -> store_extension_address and the
+//    IEntryFeeExtension.set_entry_fee_config dispatch. The extension
+//    config blob is forwarded to the extension and not persisted on the
+//    component — the extension is the sole source of truth for it.
 //    Also exercises is_entry_fee_set returning true for extension.
 // ============================================================================
 
 #[test]
-fn test_set_entry_fee_extension_stores_address_and_config() {
+fn test_set_entry_fee_extension_stores_address() {
     let mock = deploy_mock();
     let ext_addr = make_address(0xDEAD);
 
@@ -561,16 +561,9 @@ fn test_set_entry_fee_extension_stores_address_and_config() {
     );
     mock.set_entry_fee(1, entry_fee);
 
-    // Verify extension address was stored via store_extension_address bridge
-    let stored_addr = mock.get_extension_address(1);
-    assert!(stored_addr == ext_addr, "extension address mismatch");
-
-    // Verify extension config was written via write_extension_config bridge
-    let stored_config = mock.read_extension_config(1);
-    assert!(stored_config.len() == 3, "extension config should have 3 elements");
-    assert!(*stored_config.at(0) == 0x111, "config element 0 mismatch");
-    assert!(*stored_config.at(1) == 0x222, "config element 1 mismatch");
-    assert!(*stored_config.at(2) == 0x333, "config element 2 mismatch");
+    // Address is persisted on the component; config is forwarded to the
+    // extension (mocked here) and not stored.
+    assert!(mock.get_extension_address(1) == ext_addr, "extension address mismatch");
 }
 
 #[test]
@@ -614,11 +607,7 @@ fn test_set_entry_fee_extension_with_empty_config() {
     );
     mock.set_entry_fee(1, entry_fee);
 
-    let stored_addr = mock.get_extension_address(1);
-    assert!(stored_addr == ext_addr, "extension address mismatch");
-
-    let stored_config = mock.read_extension_config(1);
-    assert!(stored_config.len() == 0, "extension config should be empty");
+    assert!(mock.get_extension_address(1) == ext_addr, "extension address mismatch");
 }
 
 #[test]
@@ -640,77 +629,6 @@ fn test_get_entry_fee_returns_none_for_extension_only() {
     assert!(result.is_none(), "should be None for extension-only entry fee (no token)");
 }
 
-// ============================================================================
-// 8. Extension read/write directly via mock helpers
-//    Exercises read_extension_config and write_extension_config bridge paths.
-// ============================================================================
-
-#[test]
-fn test_extension_config_empty_by_default() {
-    let mock = deploy_mock();
-    let config = mock.read_extension_config(1);
-    assert!(config.len() == 0, "extension config should be empty by default");
-}
-
-#[test]
-fn test_write_and_read_extension_config_single_element() {
-    let mock = deploy_mock();
-
-    let config = array![0x12345].span();
-    mock.write_extension_config(1, config);
-
-    let result = mock.read_extension_config(1);
-    assert!(result.len() == 1, "should have 1 element");
-    assert!(*result.at(0) == 0x12345, "element 0 mismatch");
-}
-
-#[test]
-fn test_write_and_read_extension_config_multiple_elements() {
-    let mock = deploy_mock();
-
-    let config = array![0x111, 0x222, 0x333, 0x444, 0x555].span();
-    mock.write_extension_config(1, config);
-
-    let result = mock.read_extension_config(1);
-    assert!(result.len() == 5, "should have 5 elements");
-    assert!(*result.at(0) == 0x111, "element 0 mismatch");
-    assert!(*result.at(1) == 0x222, "element 1 mismatch");
-    assert!(*result.at(2) == 0x333, "element 2 mismatch");
-    assert!(*result.at(3) == 0x444, "element 3 mismatch");
-    assert!(*result.at(4) == 0x555, "element 4 mismatch");
-}
-
-#[test]
-fn test_extension_config_isolation_by_context() {
-    let mock = deploy_mock();
-
-    mock.write_extension_config(1, array![0xAAA, 0xBBB].span());
-    mock.write_extension_config(2, array![0xCCC].span());
-
-    let config1 = mock.read_extension_config(1);
-    let config2 = mock.read_extension_config(2);
-    let config3 = mock.read_extension_config(3);
-
-    assert!(config1.len() == 2, "context 1 should have 2 elements");
-    assert!(*config1.at(0) == 0xAAA, "context 1 element 0 mismatch");
-    assert!(*config1.at(1) == 0xBBB, "context 1 element 1 mismatch");
-
-    assert!(config2.len() == 1, "context 2 should have 1 element");
-    assert!(*config2.at(0) == 0xCCC, "context 2 element 0 mismatch");
-
-    assert!(config3.len() == 0, "context 3 should be empty");
-}
-
-#[test]
-fn test_write_extension_config_empty_span() {
-    let mock = deploy_mock();
-
-    mock.write_extension_config(1, array![].span());
-
-    let result = mock.read_extension_config(1);
-    assert!(result.len() == 0, "writing empty span should result in empty config");
-}
-
 // ============================================================================
 // 9. Extension address via get_extension_address
 // ============================================================================
@@ -862,37 +780,7 @@ fn test_exactly_16_shares_full_slot() {
 }
 
 // ============================================================================
-// 13. Extension address and config together via mock helpers
-// ============================================================================
-
-#[test]
-fn test_extension_address_and_config_together() {
-    let mock = deploy_mock();
-    let ext_addr = make_address(0xE0E0E0);
-
-    mock_extension_calls(ext_addr);
-
-    let config_data = array![0x42, 0x84, 0xFF];
-    let entry_fee = EntryFee::Extension(
-        metagame_extensions_interfaces::extension::ExtensionConfig {
-            address: ext_addr, config: config_data.span(),
-        },
-    );
-    mock.set_entry_fee(1, entry_fee);
-
-    // Verify address via get_extension bridge
-    assert!(mock.get_extension_address(1) == ext_addr, "extension address mismatch");
-
-    // Verify config via read_extension_config bridge
-    let config = mock.read_extension_config(1);
-    assert!(config.len() == 3, "config should have 3 elements");
-    assert!(*config.at(0) == 0x42, "config element 0 mismatch");
-    assert!(*config.at(1) == 0x84, "config element 1 mismatch");
-    assert!(*config.at(2) == 0xFF, "config element 2 mismatch");
-}
-
-// ============================================================================
-// 14. claim_entry_fee_extension dispatch
+// 13. claim_entry_fee_extension dispatch
 // ============================================================================
 
 #[test]