[Bug] CI not running `snarkvm-ledger` tests that require the `test` feature.

[raychu86]

CI is not running snarkvm-ledger tests that require the test feature. For instance all the valid_solutions tests here.

There may be other places as well that have tests that are not covered by CI.

[kaimast]

It looks like they are still run in the ledger-with-valid-solutions job, e.g., here.

[meddle0x53]

It is related to the partitioning so not all tests are ran in the same container (which would make the test run slow - taking +10, +20 minutes). And in this case as Kai said there is a specific workflow ledger-with-valid-solutions this makes the CI run finish faster in the end.

[raychu86]

Ah i missed that. It is still unclear to me where to add additional ledger tests that require the test feature.

For now I lumped a new test into ledger-with-valid-solutions, but I recall before we used to run everything with --all-features.

[vicsn]

CC related pending test cleanup #2979

[kaimast]

In my opinion, the cleanest option, aside from removing the test feature altogether, is to have dedicated integration tests that require the test feature and other ones that conflict with the test feature.

We already define required features for some tests in snarkVM, e.g., here. You cannot define feature conflicts in Cargo.toml but we can use compile_error! in integration tests that conflict with the test feature.