Loop with network-wide custom DNS

[DanTheMan827]

I just noticed this today when my instance would just keep forwarding to itself when trying to login to cubecraft due to my pihole redirecting that domain.

There seems to be an inconsistency with how server IPs are handled, and I'm not sure if this is a bug, or if the other ones should be obtaining the IP per the setting as well.

BedrockConnect/serverlist-server/src/main/com/pyratron/pugmatt/bedrockconnect/server/PacketHandler.java

Line 189 in 95d595b

transfer(!BedrockConnect.getConfig().canFetchFeaturedIps() ? getIP("mco.cubecraft.net") : "mco.cubecraft.net", 19132);

[Pugmatt]

This was setup intentionally based on CubeCraft's request to fix load balancing issues that was occurring on their servers from BedrockConnect players, the current intended setup is to not redirect Cubecraft in the DNS and to join BedrockConnect through the other featured servers.

That being said, I've been meaning to review this again and look into a better solution. But for now, the solution would be to remove the Cubecraft redirect from your DNS. (Or manually replace that line with transfer(getIP("mco.cubecraft.net"), 19132); and recompile a modified JAR from your end)

[hasankayra04]

I set fetch_featured_ips to false to prevent looping.
Because the server uses itself as a DNS resolver, joining a featured server from BC will connect you back to BC since the DNS points to BC.