Fix/sq create failure not 201 (#473)

* Update SavedQueryDatabaseStorageBackend.cs

Letting exception propagate

* Update SavedQueryApiController.cs

Check problem is not null    (out problem was not used/checked/read )

* Update SavedQueryDatabaseStorageBackendTests.cs

chaged test to expect an exception

Author: JohannesFinsveen

PxWeb.UnitTests/SavedQuery/SavedQueryDatabaseStorageBackendTests.cs

@@ -193,7 +193,7 @@ public void UpdatedStatistics_ShouldReturnFalse_WhenInvalidId()
         }
 
         [TestMethod]
-        public void Save_ShouldReturnEmptyString_WhenNoConnectionStringSpecified()
+        public void Save_ShouldThrowException_WhenNoConnectionStringSpecified()
         {
             // Arrange
             var options = new SavedQueryDatabaseStorageOptions
@@ -219,10 +219,7 @@ public void Save_ShouldReturnEmptyString_WhenNoConnectionStringSpecified()
             var backend = new SavedQueryDatabaseStorageBackend(mockDataSourceOptions.Object, mockStorageOptions.Object, resolver.Object);
 
             // Act
-            var result = backend.Save("", "0", "sv");
-
-            // Assert
-            Assert.AreEqual(string.Empty, result);
+            Assert.Throws<Exception>(() => backend.Save("", "0", "sv"));
 
         }
 

PxWeb/Code/Api2/SavedQueryBackend/DatabaseBackend/SavedQueryDatabaseStorageBackend.cs

@@ -53,20 +53,10 @@ public string Save(string savedQuery, string tableId, string language)
             var mainTable = _tablePathResolver.Resolve(language, tableId, out exists);
             if (!exists)
             {
-                mainTable = "?";
+                mainTable = "?";  //better to throw something isnt it?
             }
 
-            try
-            {
-                return _savedQueryDatabaseAccessor.Save(savedQuery, mainTable, null).ToString();
-            }
-            catch (Exception ex)
-            {
-                // Log the error (not implemented in this example)
-                Debug.WriteLine($"Error saving query: {ex.Message}");
-            }
-            return string.Empty;
-
+            return _savedQueryDatabaseAccessor.Save(savedQuery, mainTable, null).ToString();
         }
 
         public bool UpdateRunStatistics(string id)

PxWeb/Controllers/Api2/SavedQueryApiController.cs

@@ -62,6 +62,11 @@ public override IActionResult CreateSaveQuery([FromBody] SavedQuery? savedQuery)
 
             _dataWorkflow.Run(savedQuery.TableId, savedQuery.Language, variablesSelection, out problem);
 
+            if (problem is not null)
+            {
+                return BadRequest(problem);
+            }
+
             string id;
             try
             {