Skip to content

Commit cccefab

Browse files
committed
Refactor tests to use Assert.HasCount for collection size
Replaced Assert.AreEqual checks on collection Count with Assert.HasCount in PxUtilsProxyParserTests.cs. This improves test readability and better expresses intent without altering test logic or data.
1 parent 10ff78e commit cccefab

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

PxWeb.UnitTests/PxFile/PxUtilsProxyParserTests.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using System;
2-
using System.Text;
32
using System.Collections.Specialized;
3+
using System.Text;
4+
45
using PxWeb.PxFile;
56
using PxWeb.UnitTests.Fixtures;
67

@@ -49,7 +50,7 @@ public void ParseMeta_ParsesLanguageEntry_WithAllLanguages()
4950

5051
Assert.AreEqual(1, parser.HandlerCalls.Count(call => call.Keyword == "LANGUAGE"));
5152
Assert.AreEqual(1, parser.HandlerCalls.Count(call => call.Keyword == "LANGUAGES"));
52-
Assert.AreEqual(3, parser.HandlerCalls.First(call => call.Keyword == "LANGUAGES").Values.Count);
53+
Assert.HasCount(3, parser.HandlerCalls.First(call => call.Keyword == "LANGUAGES").Values);
5354
}
5455

5556
[TestMethod]
@@ -69,10 +70,10 @@ public void ParseMeta_StubAndHeading_ReadsCorrectly()
6970
parser.ParseMeta(parser.TestMetaHandler, preferredLanguage: "en");
7071

7172
Assert.AreEqual(3, parser.HandlerCalls.Count(call => call.Keyword == "STUB"));
72-
Assert.AreEqual(1, parser.HandlerCalls.First(call => call.Keyword == "STUB").Values.Count);
73+
Assert.HasCount(1, parser.HandlerCalls.First(call => call.Keyword == "STUB").Values);
7374
Assert.AreEqual("Year", parser.HandlerCalls.First(call => call.Keyword == "STUB" && call.Language == "en").Values[0]);
7475
Assert.AreEqual(3, parser.HandlerCalls.Count(call => call.Keyword == "HEADING"));
75-
Assert.AreEqual(1, parser.HandlerCalls.First(call => call.Keyword == "HEADING").Values.Count);
76+
Assert.HasCount(1, parser.HandlerCalls.First(call => call.Keyword == "HEADING").Values);
7677
Assert.AreEqual("Information", parser.HandlerCalls.First(call => call.Keyword == "HEADING" && call.Language == "en").Values[0]);
7778
}
7879

@@ -89,7 +90,7 @@ public void ParseMeta_YearValues_ParsedCorrectly()
8990
Assert.HasCount(1, yearValuesCalls);
9091

9192
var values = yearValuesCalls[0].Values;
92-
Assert.AreEqual(54, values.Count);
93+
Assert.HasCount(54, values);
9394
Assert.AreEqual("1970", values[0]);
9495
Assert.AreEqual("2023*", values[^1]);
9596
}

0 commit comments

Comments
 (0)