Skip to content

Do not render page_title if it is empty #655

Open
@nlhkabu

Description

In site_base.html we have the following code:

<h1>{% block page_title %}{% endblock %}</h1>

Sometimes page_title is empty and another h1 is defined later on the page.

In this case, we do not want to render the <h1> that wraps page_title.

In the short term I have issued a temporary fix, which hides the empty h1 with css.

However, this is not ideal, as the semantics of the page are messed up.

This is a suggested fix I found: https://chase-seibert.github.io/blog/2010/10/01/check-if-a-block-is-defined-in-django.html

There is also this https://github.com/edoburu/django-capture-tag

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions