Don't set MACOSX_DEPLOYMENT_TARGET for editable builds by default (#1815)

messense · web-flow · commit a8f87fdb7106 · 2023-10-24T20:34:46.000+08:00
diff --git a/src/compile.rs b/src/compile.rs
@@ -419,8 +419,8 @@ fn compile_target(
         build_command.env("PYO3_CROSS_LIB_DIR", lib_dir);
     }
 
-    // Set default macOS deployment target version
-    if target.is_macos() && env::var_os("MACOSX_DEPLOYMENT_TARGET").is_none() {
+    // Set default macOS deployment target version for non-editable builds
+    if !context.editable && target.is_macos() && env::var_os("MACOSX_DEPLOYMENT_TARGET").is_none() {
         use crate::build_context::rustc_macosx_target_version;
 
         let target_config = context

Original file line number	Diff line number	Diff line change
`@@ -419,8 +419,8 @@ fn compile_target(`
`419`	`419`	`build_command.env("PYO3_CROSS_LIB_DIR", lib_dir);`
`420`	`420`	`}`
`421`	`421`
`422`		`- // Set default macOS deployment target version`
`423`		`- if target.is_macos() && env::var_os("MACOSX_DEPLOYMENT_TARGET").is_none() {`
	`422`	`+ // Set default macOS deployment target version for non-editable builds`
	`423`	`+ if !context.editable && target.is_macos() && env::var_os("MACOSX_DEPLOYMENT_TARGET").is_none() {`
`424`	`424`	`use crate::build_context::rustc_macosx_target_version;`
`425`	`425`
`426`	`426`	`let target_config = context`