Skip to content

Commit 5c6807d

Browse files
authored
ci: remove references to generate-import-lib feature (#6127)
1 parent 0f90242 commit 5c6807d

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -695,13 +695,12 @@ jobs:
695695
# ubuntu x86_64 -> windows x86_64
696696
- os: "ubuntu-latest"
697697
target: "x86_64-pc-windows-gnu"
698-
# TODO: remove pyo3/generate-import-lib feature when maturin supports cross compiling to Windows without it
699-
flags: "-i python3.13 --features pyo3/generate-import-lib"
698+
flags: "-i python3.13"
700699
apt-packages: mingw-w64 llvm
701700
# windows x86_64 -> aarch64
702701
- os: "windows-latest"
703702
target: "aarch64-pc-windows-msvc"
704-
flags: "-i python3.13 --features pyo3/generate-import-lib"
703+
flags: "-i python3.13"
705704
steps:
706705
- uses: actions/checkout@v6.0.3
707706
with:

noxfile.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -539,8 +539,6 @@ def test_cross_compilation_windows(session: nox.Session):
539539
"build",
540540
"--manifest-path",
541541
"examples/maturin-starter/Cargo.toml",
542-
"--features",
543-
"pyo3/generate-import-lib",
544542
"--target",
545543
"x86_64-pc-windows-gnu",
546544
env=env,
@@ -553,8 +551,6 @@ def test_cross_compilation_windows(session: nox.Session):
553551
"clang",
554552
"--manifest-path",
555553
"examples/maturin-starter/Cargo.toml",
556-
"--features",
557-
"pyo3/generate-import-lib",
558554
"--target",
559555
"x86_64-pc-windows-msvc",
560556
env=env,

0 commit comments

Comments
 (0)