Skip to content

add assertions for cutout bounds, solves #158 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented May 26, 2020

Closes #158

Changes proposed in this Pull Request

See #158

It still remains to figure out whether the grid should totally include all offshore regions

  • If not, the second assertion (now commented) can be deleted
  • If yes, the second assertion has to be uncommented and the bounds of the cutout adjusted in the config.default.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to environment.yaml and environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@FabianHofmann
Copy link
Contributor Author

Closing this in favour of new PR tackling #158

@FabianHofmann FabianHofmann deleted the cutout_bounds branch June 12, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a check_config.py with basic config assertions
1 participant