Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - Adding check for valid component names #547

Closed
wants to merge 2 commits into from
Closed

[WIP] - Adding check for valid component names #547

wants to merge 2 commits into from

Conversation

whart222
Copy link
Member

@whart222 whart222 commented Jun 6, 2018

Changed the logic for adding slacks to use a Var(Any) component.

Fixes #525.

Summary/Motivation:

Adding a check to ensure that component attribute names are valid

Changes proposed in this PR:

  • Checking that component attribute names are valid
  • Reworking transformations that used '.'s in attribute names

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@whart222
Adding check for valid component names
034bc9a 
Changed the logic for adding slacks to use a Var(Any) component.
@whart222
Copy link
Member Author

whart222 commented Jun 6, 2018

@jsiirola Please rework the GDP transformations to avoid the exception being raised.

@gseastream
Copy link
Contributor

Would you mind pulling from master to try out the new testing on branches restriction? And then if that works we ideally pull the update into all the main repo's branches.

@whart222
Copy link
Member Author

whart222 commented Jun 6, 2018

@gseastream I've merged from master.

@whart222 whart222 requested review from jsiirola and DLWoodruff June 6, 2018 19:46
@jsiirola jsiirola changed the title WIP - Adding check for valid component names [WIP] - Adding check for valid component names Jun 26, 2018
@whart222
Copy link
Member Author

Per the comment in #525, I'm closing this PR due to inactivity.

@whart222 whart222 closed this Mar 18, 2020
@whart222 whart222 deleted the component_setattr branch March 18, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsiirola jsiirola Awaiting requested review from jsiirola

@DLWoodruff DLWoodruff Awaiting requested review from DLWoodruff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rethinking Pyomo component string representations
2 participants
@whart222 @gseastream