added generic fallback for coordinate-based phasespace check

Author: Uwe Hernandez Acosta

src/QEDprocesses.jl

@@ -31,11 +31,11 @@ using DocStringExtensions
 using QEDbase
 
 include("utils.jl")
+include("phase_spaces.jl")
 include("interfaces/model_interface.jl")
 include("interfaces/process_interface.jl")
 include("interfaces/setup_interface.jl")
 include("propagators.jl")
-include("phase_spaces.jl")
 include("probabilities.jl")
 include("cross_sections.jl")
 end

src/interfaces/process_interface.jl

@@ -137,6 +137,29 @@ function _averaging_norm end
 """
 function _is_in_phasespace end
 
+"""
+
+Fallback for cooridinate-based phasespace check. This function should be implemented for special cases if available.
+"""
+function _is_in_phasespace(
+        proc::AbstractProcessDefinition,
+        model::AbstractModelDefinition, 
+        in_phase_space_def::AbstractPhasespaceDefinition,
+        in_phase_space::AbstractVector{T},
+        out_phase_space_def::AbstractPhasespaceDefinition,
+        out_phase_space::AbstractVector{T}
+        ) where {T<:Real}
+    in_momenta, out_momenta = _generate_momenta(
+        proc,
+        model,
+        in_phase_space_def,
+        in_phase_space,
+        out_phase_space_def,
+        out_phase_space,
+    )
+    return _is_in_phasespace(proc,model,in_phase_space_def,in_phase_space,out_phase_space_def,out_phase_space)
+end
+
 """
     _phase_space_factor(
         proc::AbstractProcessDefinition,

src/probabilities.jl

@@ -166,7 +166,7 @@ function _probability(
     in_phase_space::AbstractVector{T},
     out_phase_space_def::AbstractPhasespaceDefinition,
     out_phase_space::AbstractVector{T},
-) where {T<:QEDbase.AbstractFourMomentum}
+) where {T<:AbstractPhasespaceElement}
     if !_is_in_phasespace(
         proc,
         model,
@@ -188,27 +188,6 @@ function _probability(
     )
 end
 
-function _probability(
-    proc::AbstractProcessDefinition,
-    model::AbstractModelDefinition,
-    in_phase_space_def::AbstractPhasespaceDefinition,
-    in_phase_space::AbstractVector{T},
-    out_phase_space_def::AbstractPhasespaceDefinition,
-    out_phase_space::AbstractVector{T},
-) where {T<:Real}
-    in_momenta, out_momenta = _generate_momenta(
-        proc,
-        model,
-        in_phase_space_def,
-        in_phase_space,
-        out_phase_space_def,
-        out_phase_space,
-    )
-    return _probability(
-        proc, model, in_phase_space_def, in_momenta, out_phase_space_def, out_momenta
-    )
-end
-
 function _probability(
     proc::AbstractProcessDefinition,
     model::AbstractModelDefinition,