fix compiler warnings for return types and QMCFiniteSize initializatino

Author: camelto2

src/QMCTools/QMCFiniteSize/QMCFiniteSize.cpp

@@ -13,7 +13,7 @@
 
 namespace qmcplusplus
 {
-QMCFiniteSize::QMCFiniteSize() : skparser(NULL), ptclPool(NULL), myRcut(0.0), myConst(0.0), P(NULL), h(0.0)
+QMCFiniteSize::QMCFiniteSize() : skparser(NULL), ptclPool(NULL), myRcut(0.0), myConst(0.0), P(NULL), h(0.0), sphericalgrid(0), myGrid(NULL)
 {
   IndexType mtheta = 80;
   IndexType mphi   = 80;
@@ -23,7 +23,7 @@ QMCFiniteSize::QMCFiniteSize() : skparser(NULL), ptclPool(NULL), myRcut(0.0), my
 }
 
 QMCFiniteSize::QMCFiniteSize(SkParserBase* skparser_i)
-    : skparser(skparser_i), ptclPool(NULL), myRcut(0.0), myConst(0.0), P(NULL), h(0.0), sphericalgrid(0)
+    : skparser(skparser_i), ptclPool(NULL), myRcut(0.0), myConst(0.0), P(NULL), h(0.0), sphericalgrid(0), myGrid(NULL)
 {
   mtheta     = 80;
   mphi       = 80;
@@ -99,10 +99,11 @@ bool QMCFiniteSize::validateXML()
   app_log() << " Summary of QMC systems \n";
   app_log() << "=========================================================\n";
   ptclPool.get(app_log());
+  return true;
 }
 
 
-bool QMCFiniteSize::wfnPut(xmlNodePtr cur)
+void QMCFiniteSize::wfnPut(xmlNodePtr cur)
 {
   std::string id("psi0"), target("e"), role("extra");
   OhmmsAttributeSet pAttrib;
@@ -640,6 +641,8 @@ bool QMCFiniteSize::execute()
   calcPotentialCorrection();
 
   summary();
+
+  return true;
 }
 
 } // namespace qmcplusplus

src/QMCTools/QMCFiniteSize/QMCFiniteSize.h

@@ -52,11 +52,12 @@ class QMCFiniteSize : public QMCAppBase, QMCTraits
   RealType myConst;
   ParticleSet* P;
   RealType h; //this is for finite differencing.
-  LRHandlerType* AA;
+  vector<PosType> sphericalgrid;
   GridType* myGrid;
+  LRHandlerType* AA;
   RadFunctorType* rVs;
   bool processPWH(xmlNodePtr cur);
-  bool wfnPut(xmlNodePtr cur);
+  void wfnPut(xmlNodePtr cur);
   void initBreakup();
   Grid_t gridx;
   Grid_t gridy;
@@ -72,7 +73,6 @@ class QMCFiniteSize : public QMCAppBase, QMCTraits
   IndexType mtheta;
   IndexType mphi;
   IndexType NumSamples;
-  vector<PosType> sphericalgrid;
   RealType Ne, Vol, rs, rho;
   RealType tlo, tloerr, vlo, vloerr, Vfs, Vfserr;
 };