Skip to content

Restrict asan suppression to only the MPI case.#5568

Merged
PDoakORNL merged 2 commits intoQMCPACK:developfrom
ye-luo:asan_supp
Jul 3, 2025
Merged

Restrict asan suppression to only the MPI case.#5568
PDoakORNL merged 2 commits intoQMCPACK:developfrom
ye-luo:asan_supp

Conversation

@ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jul 2, 2025

Proposed changes

a #5566 follow-up

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

@ye-luo ye-luo requested a review from PDoakORNL July 2, 2025 23:23
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think it would be an improvement to have a note in the printout about the suppressions being used.
  2. Have you run a comprehensive set of tests with this change? e.g. ctest -E 'long|performance' ?

@ye-luo
Copy link
Contributor Author

ye-luo commented Jul 3, 2025

  1. I think it would be an improvement to have a note in the printout about the suppressions being used.

Got LSAN_OPTION printed if it is not empty.

2. Have you run a comprehensive set of tests with this change? e.g. ctest -E 'long|performance' ?

No. Only ran the whole deterministic category which covers unit tests and some full simulation runs. They pass on my workstation.

@ye-luo
Copy link
Contributor Author

ye-luo commented Jul 3, 2025

Test this please

Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The suppression list wasn't made for nonmpi case.

@PDoakORNL PDoakORNL merged commit 7af0844 into QMCPACK:develop Jul 3, 2025
41 checks passed
@ye-luo ye-luo deleted the asan_supp branch August 3, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants