Restrict asan suppression to only the MPI case.#5568
Merged
PDoakORNL merged 2 commits intoQMCPACK:developfrom Jul 3, 2025
Merged
Restrict asan suppression to only the MPI case.#5568PDoakORNL merged 2 commits intoQMCPACK:developfrom
PDoakORNL merged 2 commits intoQMCPACK:developfrom
Conversation
prckent
reviewed
Jul 3, 2025
Contributor
prckent
left a comment
There was a problem hiding this comment.
- I think it would be an improvement to have a note in the printout about the suppressions being used.
- Have you run a comprehensive set of tests with this change? e.g. ctest -E 'long|performance' ?
Contributor
Author
Got LSAN_OPTION printed if it is not empty.
No. Only ran the whole deterministic category which covers unit tests and some full simulation runs. They pass on my workstation. |
Contributor
Author
|
Test this please |
PDoakORNL
approved these changes
Jul 3, 2025
Contributor
PDoakORNL
left a comment
There was a problem hiding this comment.
This looks good to me. The suppression list wasn't made for nonmpi case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
a #5566 follow-up
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist