Skip to content

Commit 38cd74e

Browse files
authored
Merge pull request #1681 from amitsharma322/gli-2684
Fixed: Cart rule creation at booking time failed if no prior cart rules existed.
2 parents 7ced5de + 054a4a8 commit 38cd74e

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

classes/CartRule.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1477,10 +1477,7 @@ public static function autoAddToCart(?Context $context = null)
14771477
*/
14781478
public static function isFeatureActive()
14791479
{
1480-
static $is_feature_active = null;
1481-
if ($is_feature_active === null) {
1482-
$is_feature_active = (bool)Configuration::get('PS_CART_RULE_FEATURE_ACTIVE');
1483-
}
1480+
$is_feature_active = (bool)Configuration::get('PS_CART_RULE_FEATURE_ACTIVE');
14841481
return $is_feature_active;
14851482
}
14861483

classes/webservice/WebserviceSpecificManagementBookings.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ public function formatRoomInRequestData($data)
507507
$formattedRooms[$key]['occupancy'] = $occupancy;
508508
if (isset($room['id_tax_rules_group'])) {
509509
$formattedRooms[$key]['id_tax_rules_group'] = $room['id_tax_rules_group'];
510-
} else if ($room['total_tax']) {
510+
} else if (isset($room['total_tax'])) {
511511
$formattedRooms[$key]['total_tax'] = $room['total_tax'];
512512
}
513513
}

0 commit comments

Comments
 (0)