Skip to content

Fix type promotion, use promote_rule instead of promote_type #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Fix type promotion, use promote_rule instead of promote_type #58

merged 1 commit into from
Mar 3, 2025

Conversation

GiggleLiu
Copy link
Member

fix #57

@GiggleLiu
Copy link
Member Author

Remark: the nightly test fails due to not passing the allocation test at 31-th line of test/longlonguint.jl. No idea how to fix it at the moment, so I will merge this PR directly.

@GiggleLiu GiggleLiu merged commit 0b7c3c0 into master Mar 3, 2025
2 of 4 checks passed
@GiggleLiu GiggleLiu deleted the jg/fix-promote branch March 3, 2025 01:56
@nsajko
Copy link

nsajko commented Mar 3, 2025

the nightly test fails due to not passing the allocation test

Possibly a false positive due to JuliaLang/julia#57064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsajko nsajko nsajko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding methods to promote_type is not allowed
2 participants
@GiggleLiu @nsajko