Skip to content

fix stiefelexp#20

Merged
Jutho merged 2 commits into
masterfrom
jh/fixstiefel
Dec 12, 2025
Merged

fix stiefelexp#20
Jutho merged 2 commits into
masterfrom
jh/fixstiefel

Conversation

@Jutho
Copy link
Copy Markdown
Member

@Jutho Jutho commented Dec 11, 2025

This should fix #18 . Maybe a small review by @lkdvos or @KVerv ?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.63%. Comparing base (6ed66c1) to head (d281f3b).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   72.57%   72.63%   +0.05%     
==========================================
  Files           5        5              
  Lines         485      486       +1     
==========================================
+ Hits          352      353       +1     
  Misses        133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Copy link
Copy Markdown
Member Author

Jutho commented Dec 11, 2025

Also, after this PR is merged, I consider moving this to QuantumKitHub and changing the formatting to Runic etc.

Comment thread src/stiefel.jl Outdated
Copy link
Copy Markdown
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks reasonable to me, left a minor comment but I don't think this matters all that much

Co-authored-by: Lukas Devos <ldevos98@gmail.com>
@Jutho Jutho merged commit 00d73d9 into master Dec 12, 2025
11 of 12 checks passed
@Jutho Jutho deleted the jh/fixstiefel branch December 12, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling of the square case for Stiefel manifold

2 participants