Skip to content

Commit 7747d2f

Browse files
kshyattJutho
andauthored
Apply Jutho's cleanup suggestions
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
1 parent f779b68 commit 7747d2f

1 file changed

Lines changed: 3 additions & 11 deletions

File tree

ext/VectorInterfaceMooncakeExt.jl

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,7 @@ function Mooncake.frule!!(::Dual{typeof(scale!)}, C_ΔC::Dual{<:AbstractArray},
8888
α, Δα = extract(α_Δα)
8989

9090
scale!(ΔC, ΔA, α)
91-
if !isa(Δα, NoTangent)
92-
add!(ΔC, A, Δα, One())
93-
end
91+
!isa(Δα, NoTangent) && add!(ΔC, A, Δα, One())
9492
scale!(C, A, α)
9593
return C_ΔC
9694
end
@@ -132,14 +130,8 @@ function Mooncake.frule!!(::Dual{typeof(add!)}, C_ΔC::Dual{<:AbstractArray}, A_
132130
α, Δα = extract(α_Δα)
133131
β, Δβ = extract(β_Δβ)
134132
add!(ΔC, ΔA, α, β)
135-
if isa(Δβ, NoTangent) && !isa(Δα, NoTangent)
136-
add!(ΔC, A, Δα, One())
137-
elseif isa(Δα, NoTangent) && !isa(Δβ, NoTangent)
138-
add!(ΔC, C, Δβ, One())
139-
elseif !isa(Δα, NoTangent) && !isa(Δβ, NoTangent)
140-
add!(ΔC, A, Δα, One())
141-
add!(ΔC, C, Δβ, One())
142-
end
133+
!isa(Δα, NoTangent) && add!(ΔC, A, Δα, One())
134+
!isa(Δβ, NoTangent) && add!(ΔC, C, Δβ, One())
143135
add!(C, A, α, β)
144136
return C_ΔC
145137
end

0 commit comments

Comments
 (0)