Can't build schematic_file.cpp with MinGW - expected type-specifier before 'Rectangle'

[Luddite-Geekazoid]

I get these errors:

schematic_file.cpp: In member function 'bool Schematic::loadPaintings(QTextStream*, SharedObjectList&)': schematic_file.cpp:683:42: error: expected type-specifier before 'Rectangle'
683 | else if(cstr == "Rectangle") p = new Rectangle();
| ^~~~~~~~~
schematic_file.cpp:685:40: error: expected type-specifier before 'Ellipse'
685 | else if(cstr == "Ellipse") p = new Ellipse();
| ^~~~~~~
make[3]: *** [Makefile:904: schematic_file.lo] Error 1
rm qucs_.cpp

The source code has similar statements that don't result in an error:
#` cstr = Line.section(' ',0,0); // painting type

     if(cstr == "Line") p = new GraphicLine();

else if(cstr == "EArc") p = new EllipseArc();

else if(cstr == ".PortSym") p = new PortSymbol();

else if(cstr == ".ID") p = new ID_Text();

else if(cstr == "Text") p = new GraphicText();


else if(cstr == "Rectangle") p = new Rectangle();

else if(cstr == "Arrow") p = new Arrow();

else if(cstr == "Ellipse") p = new Ellipse();

else {

  QMessageBox::critical(0, QObject::tr("Error"),

	QObject::tr("Format Error:\nUnknown painting: ") + Line);

  return false;

}`

msys64 installed from msys2-x86_64-20250830.exe
Windows 10, 22H2, 10.0.19045 Build 19045
qucs 0.0.21-dev cloned 2025-10-23 20:08 UTC

[felix-salfelder]

On Thu, Oct 23, 2025 at 05:16:14PM -0700, Luddite Geek wrote: Luddite-Geekazoid created an issue (Qucs/qucs#1109) I get these errors: schematic_file.cpp: In member function 'bool Schematic::loadPaintings(QTextStream*, SharedObjectList<Element>&)': schematic_file.cpp:683:42: error: expected type-specifier before 'Rectangle' 683 | else if(cstr == "Rectangle") p = new Rectangle(); | ^~~~~~~~~

Here's a wild guess. It might have to do with a header that is only used in mingw builds. Some preprocessor hack might mask the unwanted identifiers. Find something like #ifdef mingw #include "header_in_question" #endif and replace with #ifdef mingw #define Rectangle unwanted_rectangle #include "header_in_question" #undef Rectangle #endif A proper solution would also be nice, but will require some rewrite of the dispatch, and remove those identifiers from the public namespace...

[Luddite-Geekazoid]

On Fri, Oct 24, 2025 at 6:12 AM felix ***@***.***> wrote: *felix-salfelder* left a comment (Qucs/qucs#1109) <#1109 (comment)> On Thu, Oct 23, 2025 at 05:16:14PM -0700, Luddite Geek wrote: > Luddite-Geekazoid created an issue (Qucs/qucs#1109) > > I get these errors: > > schematic_file.cpp: In member function 'bool Schematic::loadPaintings(QTextStream*, SharedObjectList<Element>&)': schematic_file.cpp:683:42: error: expected type-specifier before 'Rectangle' > 683 | else if(cstr == "Rectangle") p = new Rectangle(); > | ^~~~~~~~~ Here's a wild guess. It might have to do with a header that is only used in mingw builds. Some preprocessor hack might mask the unwanted identifiers. Find something like #ifdef mingw #include "header_in_question" #endif and replace with #ifdef mingw #define Rectangle unwanted_rectangle #include "header_in_question" #undef Rectangle #endif A proper solution would also be nice, but will require some rewrite of the dispatch, and remove those identifiers from the public namespace...

I found only one instance of an include statement when *mingw* is defined, in simmessage.cpp, I replaced the first block of code with the second block of code, but I got the same result. However, seeing the test for MINGW**32** made me wonder if I should be using the mingw32 environment rather than mingw64. But it seems the configure script makes no distinction between the two; it looks for *mingw* only, setting WIN32 in either case. I'll try compiling the master branch (0.0.20) with an old version of MinGW (with Qt4) and work with that. I won't mind if this issue is closed. #ifdef __MINGW32__ #include <windows.h> static QString pathName(QString longpath) { const char * lpath = QDir::toNativeSeparators(longpath).toLatin1(); char spath[2048]; int len = GetShortPathNameA(lpath,spath,sizeof(spath)-1); spath[len] = '\0'; return QString(spath); } #else static QString pathName(QString longpath) { return longpath; } #endif #ifdef __MINGW32__ #define Rectangle unwanted_rectangle #include <windows.h> #undef Rectangle static QString pathName(QString longpath) { const char * lpath = QDir::toNativeSeparators(longpath).toLatin1(); char spath[2048]; int len = GetShortPathNameA(lpath,spath,sizeof(spath)-1); spath[len] = '\0'; return QString(spath); } #else static QString pathName(QString longpath) { return longpath; } #endif