revert: install pgbadger from source

Author: Xetera

.github/workflows/custom.yaml

@@ -43,6 +43,8 @@ jobs:
 
       - name: Run local GitHub Action
         uses: ./
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           postgres_url: http://query_doctor@localhost:5432/testing

action.yaml

@@ -7,7 +7,7 @@ description: "Query Doctor"
 inputs:
   github_token:
     description: "GitHub token"
-    required: false
+    required: true
   begin_date:
     description: "Begin date to start analyzing logs"
     required: false
@@ -33,7 +33,20 @@ runs:
       shell: bash
       run: |
         sudo apt-get update
-        sudo apt-get install -y pgbadger
+        sudo apt-get install -y perl make wget
+
+    # Download, build, and install pgBadger
+    - name: Download and Install pgBadger
+      shell: bash
+      run: |
+        PGBADGER_VERSION=13.1
+        cd /tmp
+        wget https://github.com/darold/pgbadger/archive/v${PGBADGER_VERSION}.tar.gz -O pgbadger.tar.gz
+        tar -xzf pgbadger.tar.gz
+        cd pgbadger-${PGBADGER_VERSION}
+        perl Makefile.PL
+        sudo make install # Use sudo to install globally
+        cd ${{ github.action_path }} # Return to action directory
 
     # Compile the Deno application into a single executable
     - name: Compile Analyzer

bootstrap.sql

@@ -383,7 +383,7 @@ from
       "assets"."inserted_at" desc
     limit
       100
-  ) "userAssets"
+  ) "userAssets";
 
 --
 -- PostgreSQL database dump complete

main.ts

@@ -23,8 +23,6 @@ function formatQuery(query: string) {
 }
 
 async function main() {
-  console.log(process.env.GITHUB_WORKSPACE);
-  // console.log([...Deno.readDirSync(process.env.GITHUB_WORKSPACE!)]);
   const logPath = process.env.LOG_PATH || core.getInput("log_path");
   const postgresUrl = process.env.POSTGRES_URL || core.getInput("postgres_url");
   console.log(logPath);
@@ -184,9 +182,7 @@ async function main() {
       }
     }
   }
-  const reporter = new GithubReporter(
-    core.getInput("github_token", { required: true })
-  );
+  const reporter = new GithubReporter(process.env.GITHUB_TOKEN);
   await reporter.report({ recommendations });
   console.timeEnd("total");
   await output.status;

optimizer/genalgo.ts

@@ -41,7 +41,7 @@ export class IndexOptimizer {
           console.log(
             `index definition already exists, skipping: ${existingIndex.index_name}`
           );
-          iter = permutations.next(SKIP);
+          iter = permutations.next(PROCEED);
           console.log("--------------------------------");
           continue;
         }

reporters/github.ts

@@ -4,7 +4,7 @@ import dedent from "dedent";
 export class GithubReporter {
   private static readonly REVIEW_COMMENT_SUFFIX = "<!-- qd-review-comment -->";
   prNumber?: number;
-  constructor(private readonly githubToken: string) {
+  constructor(private readonly githubToken?: string) {
     this.prNumber = github.context.payload.pull_request?.number;
   }
 
@@ -13,6 +13,10 @@ export class GithubReporter {
       console.warn(`Not a PR, skipping report...`);
       return;
     }
+    if (!this.githubToken) {
+      console.warn(`No GitHub token provided, skipping report...`);
+      return;
+    }
     const octokit = github.getOctokit(this.githubToken);
     // check if a review from us already exists
     const reviews = await octokit.rest.pulls.listReviews({
@@ -32,10 +36,13 @@ export class GithubReporter {
       <details>
       <summary>Optimized query cost (${r.baseCost} -> ${
         r.optimizedCost
-      }) by <b>${(((r.baseCost - r.optimizedCost) / r.baseCost) * 100).toFixed(
-        2
-      )}%</b></summary>
+      }) by <strong>${(
+        ((r.baseCost - r.optimizedCost) / r.baseCost) *
+        100
+      ).toFixed(2)}%</strong></summary>
+      \`\`\`sql
       ${r.formattedQuery}
+      \`\`\`
 
       Base cost: ${r.baseCost}
       Optimized cost: ${r.optimizedCost}
@@ -65,8 +72,7 @@ export class GithubReporter {
     `;
     } else {
       review = dedent`
-      # Your queries are already optimized!
-      We didn't find any queries that could be optimized. Keep up the good work!
+      # Your queries are optimized!
       ${GithubReporter.REVIEW_COMMENT_SUFFIX}
     `;
     }