Skip to content

Commit ca2b5be

Browse files
authored
Run query on Command-Enter (#2)
1 parent 6b16e7d commit ca2b5be

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/components/App/ObservabilityQueryLanguageComponent.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export default function ObservabilityQueryLanguageComponent() {
101101
}, []); // Add empty dependency array to run once
102102

103103
useEffect(() => {
104-
105104
setIsLoading(true);
106105
setError(null);
107106

@@ -164,9 +163,9 @@ export default function ObservabilityQueryLanguageComponent() {
164163
}, []);
165164

166165
const runQuery = useCallback(() => {
167-
setActiveQuery(query);
166+
setActiveQuery(queryRef.current);
168167
setQueryTimestamp(Date.now());
169-
}, [query]);
168+
}, [setActiveQuery, setQueryTimestamp]);
170169

171170
const handleGlyphClick = useCallback((lineNumber: number, isPlay: boolean) => {
172171
const lines = queryRef.current.split('\n');
@@ -279,6 +278,10 @@ export default function ObservabilityQueryLanguageComponent() {
279278
setShowAiModal(true);
280279
}, []);
281280

281+
const handleQueryChange = useCallback((value: string) => {
282+
setQuery(value);
283+
}, [setQuery]);
284+
282285
return (
283286
<div style={{ paddingLeft: '20px', paddingRight: '20px', paddingTop: '10px', colorScheme: 'dark' }}>
284287
<h3><img src={logo} alt="Quesma Logo" style={{ height: '35px' }} /> - Observability Query Language</h3>
@@ -348,13 +351,14 @@ export default function ObservabilityQueryLanguageComponent() {
348351

349352
<Editor
350353
query={query}
351-
onChange={useCallback((value: string) => setQuery(value), [setQuery])}
354+
onChange={handleQueryChange}
352355
startDate={startDate}
353356
endDate={endDate}
354357
tableDefinitions={tableDefinitions}
355358
tableName={currentTable}
356359
onGlyphClick={handleGlyphClick}
357360
onAiModalOpen={handleAiModalOpen}
361+
onEnter={runQuery}
358362
/>
359363
</div>
360364

src/components/editor/Editor.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,14 +235,15 @@ export const Editor: React.FC<EditorProps> = ({ query, onChange, startDate, endD
235235
return () => window.removeEventListener('mousemove', handleMouseMove);
236236
}, []);
237237

238-
initPipeSQLLanguage();
238+
useEffect(() => {
239+
initPipeSQLLanguage();
240+
}, []);
239241

240242
const handleEditorDidMount = (editor: monaco.editor.IStandaloneCodeEditor, monaco: typeof import('monaco-editor')) => {
241243
editorRef.current = editor;
242244

243245
// Register language
244246

245-
246247
// Add command for Ctrl/Cmd + Enter
247248
editor.addCommand(monaco.KeyMod.CtrlCmd | monaco.KeyCode.Enter, () => {
248249
if (onEnter) {

0 commit comments

Comments
 (0)