Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 00f0922

Browse files
authored
Unskip 1 test which works (#1011)
1 parent 7a52524 commit 00f0922

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

quesma/queryparser/pancake_sql_query_generation_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ func TestPancakeQueryGeneration(t *testing.T) {
6262
t.Skip("Need to implement order by top metrics (talk with Jacek, he has an idea)")
6363
}
6464

65-
if test.TestName == "multiple buckets_path(file:clients/clover,nr:1)" {
66-
t.Skip("This needs fixing ASAP, easy to fix")
67-
}
68-
6965
if test.TestName == "max_bucket. Reproduce: Visualize -> Line: Metrics: Max Bucket (Bucket: Filters, Metric: Sum)(file:opensearch-visualize/pipeline_agg_req,nr:20)" ||
7066
test.TestName == "complex max_bucket. Reproduce: Visualize -> Line: Metrics: Max Bucket (Bucket: Filters, Metric: Sum), Buckets: Split chart: Rows -> Range(file:opensearch-visualize/pipeline_agg_req,nr:21)" {
7167
t.Skip("Was skipped before. Wrong key in max_bucket, should be an easy fix")

quesma/testdata/clients/clover.go

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,13 @@ var CloverTests = []testdata.AggregationTestCase{
231231
"field": "@timestamp"
232232
},
233233
"meta": {
234-
"indexPatternString": "ab*",
235-
"intervalString": "900000ms",
234+
"dataViewId": "d3d7af60-4c81-11e8-b3d7-01146121b73d",
235+
"indexPatternString": "kibana_sample_data_flights",
236+
"intervalString": "54000000ms",
236237
"normalized": true,
237-
"panelId": "0",
238-
"seriesId": "1",
239-
"timeField": "@timestamp"
238+
"panelId": "1a1d745d-0c21-4103-a2ae-df41d4fbd366",
239+
"seriesId": "866fb08f-b9a4-43eb-a400-38ebb6c13aed",
240+
"timeField": "timestamp"
240241
}
241242
}
242243
},
@@ -298,14 +299,20 @@ var CloverTests = []testdata.AggregationTestCase{
298299
"buckets": [
299300
{
300301
"a2": {
301-
"value": 202.0
302+
"value": 1
303+
},
304+
"a2-denominator": {
305+
"doc_count": 202
306+
},
307+
"a2-numerator": {
308+
"doc_count": 202
302309
},
303310
"doc_count": 202,
304-
"key": 1728518400000,
305-
"key_as_string": "2024-10-10T00:00:00.000Z"
311+
"key": 1728640683723,
312+
"key_as_string": "2024-10-11T09:58:03.723"
306313
}
307314
],
308-
"interval": "7d",
315+
"interval": "100y",
309316
"meta": {
310317
"dataViewId": "d3d7af60-4c81-11e8-b3d7-01146121b73d",
311318
"indexPatternString": "kibana_sample_data_flights",

0 commit comments

Comments
 (0)