Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 0fe3bd7

Browse files
authored
Separate test functions into t.Run()'s (#889)
Using `t.Run(` (see [Go docs](https://pkg.go.dev/testing#T.Run)) to have each function as a separate test. Looks pretty neat in IDE and will make tracing errors in the future easier 😉 ![image (23)](https://github.com/user-attachments/assets/27fce951-fefe-438b-aa81-106c54ec21e7)
1 parent b0f7b37 commit 0fe3bd7

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

ci/it/testcases/test_dual_write_and_common_table.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ func (a *DualWriteAndCommonTableTestcase) SetupContainers(ctx context.Context) e
3434
}
3535

3636
func (a *DualWriteAndCommonTableTestcase) RunTests(ctx context.Context, t *testing.T) error {
37-
a.testBasicRequest(ctx, t)
38-
a.testIngestToClickHouseWorks(ctx, t)
39-
a.testIngestToCommonTableWorks(ctx, t)
40-
a.testDualQueryReturnsDataFromClickHouse(ctx, t)
41-
a.testDualWritesWork(ctx, t)
42-
a.testWildcardGoesToElastic(ctx, t)
37+
t.Run("test basic request", func(t *testing.T) { a.testBasicRequest(ctx, t) })
38+
t.Run("test ingest to clickhouse works", func(t *testing.T) { a.testIngestToClickHouseWorks(ctx, t) })
39+
t.Run("test ingest to common table works", func(t *testing.T) { a.testIngestToCommonTableWorks(ctx, t) })
40+
t.Run("test dual query returns data from clickhouse", func(t *testing.T) { a.testDualQueryReturnsDataFromClickHouse(ctx, t) })
41+
t.Run("test dual writes work", func(t *testing.T) { a.testDualWritesWork(ctx, t) })
42+
t.Run("test wildcard goes to elastic", func(t *testing.T) { a.testWildcardGoesToElastic(ctx, t) })
4343
return nil
4444
}
4545

ci/it/testcases/test_reading_clickhouse_tables.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ func (a *ReadingClickHouseTablesIntegrationTestcase) SetupContainers(ctx context
3434
}
3535

3636
func (a *ReadingClickHouseTablesIntegrationTestcase) RunTests(ctx context.Context, t *testing.T) error {
37-
a.testBasicRequest(ctx, t)
38-
a.testRandomThing(ctx, t)
39-
a.testWildcardGoesToElastic(ctx, t)
37+
t.Run("test basic request", func(t *testing.T) { a.testBasicRequest(ctx, t) })
38+
t.Run("test random thing", func(t *testing.T) { a.testRandomThing(ctx, t) })
39+
t.Run("test wildcard goes to elastic", func(t *testing.T) { a.testWildcardGoesToElastic(ctx, t) })
4040
return nil
4141
}
4242

ci/it/testcases/test_transparent_proxy.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ func (a *TransparentProxyIntegrationTestcase) SetupContainers(ctx context.Contex
3333
}
3434

3535
func (a *TransparentProxyIntegrationTestcase) RunTests(ctx context.Context, t *testing.T) error {
36-
a.testBasicRequest(ctx, t)
37-
a.testIfCatHealthRequestReachesElasticsearch(ctx, t)
38-
a.testIfIndexCreationWorks(ctx, t)
36+
t.Run("test basic request", func(t *testing.T) { a.testBasicRequest(ctx, t) })
37+
t.Run("test if cat health request reaches elasticsearch", func(t *testing.T) { a.testIfCatHealthRequestReachesElasticsearch(ctx, t) })
38+
t.Run("test if index creation works", func(t *testing.T) { a.testIfIndexCreationWorks(ctx, t) })
3939
return nil
4040
}
4141

ci/it/testcases/test_two_pipelines.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ func (a *QueryAndIngestPipelineTestcase) SetupContainers(ctx context.Context) er
3434
}
3535

3636
func (a *QueryAndIngestPipelineTestcase) RunTests(ctx context.Context, t *testing.T) error {
37-
a.testBasicRequest(ctx, t)
38-
a.testWildcardGoesToElastic(ctx, t)
39-
a.testEmptyTargetDoc(ctx, t)
40-
a.testEmptyTargetBulk(ctx, t)
37+
t.Run("test basic request", func(t *testing.T) { a.testBasicRequest(ctx, t) })
38+
t.Run("test wildcard goes to elastic", func(t *testing.T) { a.testWildcardGoesToElastic(ctx, t) })
39+
t.Run("test empty target doc", func(t *testing.T) { a.testEmptyTargetDoc(ctx, t) })
40+
t.Run("test empty target bulk", func(t *testing.T) { a.testEmptyTargetBulk(ctx, t) })
4141
return nil
4242
}
4343

0 commit comments

Comments
 (0)