PathMutex missing features (#1088)

Author: pdelewski

quesma/frontend_connectors/basic_http_frontend_connector.go

@@ -15,15 +15,13 @@ import (
 )
 
 type HTTPRouter struct {
-	mux             *http.ServeMux                     // Default HTTP multiplexer
 	handlers        map[string]quesma_api.HandlersPipe // Map to store custom route handlers
 	fallbackHandler quesma_api.HTTPFrontendHandler
 	mutex           sync.RWMutex // Mutex for concurrent access to handlers
 }
 
 func NewHTTPRouter() *HTTPRouter {
 	return &HTTPRouter{
-		mux:      http.NewServeMux(),
 		handlers: make(map[string]quesma_api.HandlersPipe),
 	}
 }

quesma/frontend_connectors/elasticsearch_ingest.go

@@ -33,7 +33,7 @@ func NewElasticsearchIngestFrontendConnector(endpoint string) *ElasticsearchInge
 			responseMutator: setContentType,
 		},
 	}
-	router := NewHTTPRouter()
+	router := quesma_api.NewPathRouter()
 	router.AddRoute(IndexBulkPath, bulk)
 	router.AddRoute(IndexDocPath, doc)
 	fc.AddRouter(router)

quesma/main_test.go

@@ -64,7 +64,7 @@ func ab_testing_scenario() quesma_api.QuesmaBuilder {
 	var quesmaBuilder quesma_api.QuesmaBuilder = quesma_api.NewQuesma()
 
 	ingestFrontendConnector := frontend_connectors.NewBasicHTTPFrontendConnector(":8888")
-	ingestHTTPRouter := frontend_connectors.NewHTTPRouter()
+	ingestHTTPRouter := quesma_api.NewPathRouter()
 	ingestHTTPRouter.AddRoute("/_bulk", bulk)
 	ingestHTTPRouter.AddRoute("/_doc", doc)
 	ingestFrontendConnector.AddRouter(ingestHTTPRouter)
@@ -82,7 +82,7 @@ func ab_testing_scenario() quesma_api.QuesmaBuilder {
 	ingestPipeline.AddProcessor(abIngestTestProcessor)
 
 	queryFrontendConnector := frontend_connectors.NewBasicHTTPFrontendConnector(":8888")
-	queryHTTPRouter := frontend_connectors.NewHTTPRouter()
+	queryHTTPRouter := quesma_api.NewPathRouter()
 	queryHTTPRouter.AddRoute("/_search", search)
 	queryFrontendConnector.AddRouter(queryHTTPRouter)
 	var queryPipeline quesma_api.PipelineBuilder = quesma_api.NewPipeline()

quesma/v2/core/mux.go

@@ -6,13 +6,13 @@ import (
 	"github.com/ucarion/urlpath"
 	"net/http"
 	"net/url"
-
 	"strings"
 )
 
 type (
 	PathRouter struct {
-		mappings []mapping
+		mappings        []mapping
+		fallbackHandler HTTPFrontendHandler
 	}
 	mapping struct {
 		pattern      string
@@ -92,7 +92,6 @@ func (p *PathRouter) Clone() Cloner {
 }
 
 func (p *PathRouter) Register(pattern string, predicate RequestMatcher, handler HTTPFrontendHandler) {
-
 	mapping := mapping{pattern, urlpath.New(pattern), predicate, &HandlersPipe{Handler: handler}}
 	p.mappings = append(p.mappings, mapping)
 
@@ -186,15 +185,13 @@ func Always() RequestMatcher {
 }
 
 func (p *PathRouter) AddRoute(path string, handler HTTPFrontendHandler) {
-	// TODO: it seems that we can adapt this to register call
-	// p.Register(path, Always(), handler)
-	panic("not implemented")
+	p.Register(path, Always(), handler)
 }
 func (p *PathRouter) AddFallbackHandler(handler HTTPFrontendHandler) {
-	panic("not implemented")
+	p.fallbackHandler = handler
 }
 func (p *PathRouter) GetFallbackHandler() HTTPFrontendHandler {
-	panic("not implemented")
+	return p.fallbackHandler
 }
 func (p *PathRouter) GetHandlers() map[string]HandlersPipe {
 	callInfos := make(map[string]HandlersPipe)