Remove dead code or tests that are utterly useless by now (#1110)

Author: trzysiek

quesma/queryparser/query_parser.go

@@ -217,36 +217,6 @@ func (cw *ClickhouseQueryTranslator) ParseHighlighter(queryMap QueryMap) model.H
 	return highlighter
 }
 
-func (cw *ClickhouseQueryTranslator) ParseQueryAsyncSearch(queryAsJson string) (model.SimpleQuery, model.HitsCountInfo, model.Highlighter) {
-	queryAsMap, err := types.ParseJSON(queryAsJson)
-	if err != nil {
-		logger.ErrorWithCtx(cw.Ctx).Err(err).Msg("error parsing query request's JSON")
-		return model.NewSimpleQuery(nil, false), model.NewEmptyHitsCountInfo(), NewEmptyHighlighter()
-	}
-
-	// we must parse "highlights" here, because it is stripped from the queryAsMap later
-	highlighter := cw.ParseHighlighter(queryAsMap)
-
-	var parsedQuery model.SimpleQuery
-	if query, ok := queryAsMap["query"]; ok {
-		queryMap, ok := query.(QueryMap)
-		if !ok {
-			logger.WarnWithCtx(cw.Ctx).Msgf("invalid query type: %T, value: %v", query, query)
-			return model.NewSimpleQuery(nil, false), model.NewEmptyHitsCountInfo(), NewEmptyHighlighter()
-		}
-		parsedQuery = cw.parseQueryMap(queryMap)
-	} else {
-		return model.NewSimpleQuery(nil, true), cw.tryProcessSearchMetadata(queryAsMap), highlighter
-	}
-
-	if sort, ok := queryAsMap["sort"]; ok {
-		parsedQuery.OrderBy = cw.parseSortFields(sort)
-	}
-	queryInfo := cw.tryProcessSearchMetadata(queryAsMap)
-
-	return parsedQuery, queryInfo, highlighter
-}
-
 // Metadata attributes are the ones that are on the same level as query tag
 // They are moved into separate map for further processing if needed
 func (cw *ClickhouseQueryTranslator) parseMetadata(queryMap QueryMap) QueryMap {

quesma/queryparser/query_parser_async_search_test.go

@@ -213,212 +213,6 @@ func TestQueryParserNoAttrsConfig(t *testing.T) {
 	}
 }
 
-// TODO this will be updated in the next PR
-var tests = []string{
-	`{
-		"_source": {
-			"excludes": []
-		},
-		"aggs": {
-			"0": {
-				"histogram": {
-					"field": "FlightDelayMin",
-					"interval": 1,
-					"min_doc_count": 1
-				}
-			}
-		},
-		"fields": [
-			{
-				"field": "timestamp",
-				"format": "date_time"
-			}
-		],
-		"query": {
-			"bool": {
-				"filter": [
-					{
-						"range": {
-							"timestamp": {
-								"format": "strict_date_optional_time",
-								"gte": "2024-02-02T13:47:16.029Z",
-								"lte": "2024-02-09T13:47:16.029Z"
-							}
-						}
-					}
-				],
-				"must": [],
-				"must_not": [
-					{
-						"match_phrase": {
-							"FlightDelayMin": {
-								"query": 0
-							}
-						}
-					}
-				],
-				"should": []
-			}
-		},
-		"runtime_mappings": {
-			"hour_of_day": {
-				"script": {
-					"source": "emit(doc['timestamp'].value.getHour());"
-				},
-				"type": "long"
-			}
-		},
-		"script_fields": {},
-		"size": 0,
-		"stored_fields": [
-			"*"
-		],
-		"track_total_hits": true
-	}`,
-	`{
-		"_source": {
-			"excludes": []
-		},
-		"aggs": {
-			"0": {
-				"aggs": {
-					"1-bucket": {
-						"filter": {
-							"bool": {
-								"filter": [
-									{
-										"bool": {
-											"minimum_should_match": 1,
-											"should": [
-												{
-													"match": {
-														"FlightDelay": true
-													}
-												}
-											]
-										}
-									}
-								],
-								"must": [],
-								"must_not": [],
-								"should": []
-							}
-						}
-					},
-					"3-bucket": {
-						"filter": {
-							"bool": {
-								"filter": [
-									{
-										"bool": {
-											"minimum_should_match": 1,
-											"should": [
-												{
-													"match": {
-														"Cancelled": true
-													}
-												}
-											]
-										}
-									}
-								],
-								"must": [],
-								"must_not": [],
-								"should": []
-							}
-						}
-					}
-				},
-				"terms": {
-					"field": "OriginCityName",
-					"order": {
-						"_key": "asc"
-					},
-					"size": 1000
-				}
-			}
-		},
-		"fields": [
-			{
-				"field": "timestamp",
-				"format": "date_time"
-			}
-		],
-		"query": {
-			"bool": {
-				"filter": [
-					{
-						"range": {
-							"timestamp": {
-								"format": "strict_date_optional_time",
-								"gte": "2024-02-02T13:47:16.029Z",
-								"lte": "2024-02-09T13:47:16.029Z"
-							}
-						}
-					}
-				],
-				"must": [],
-				"must_not": [],
-				"should": []
-			}
-		},
-		"runtime_mappings": {
-			"hour_of_day": {
-				"script": {
-					"source": "emit(doc['timestamp'].value.getHour());"
-				},
-				"type": "long"
-			}
-		},
-		"script_fields": {},
-		"size": 0,
-		"stored_fields": [
-			"*"
-		],
-		"track_total_hits": true
-	}`,
-}
-
-// TODO this will be updated in the next PR
-func TestNew(t *testing.T) {
-	tableName := `"logs-generic-default"`
-	table, err := clickhouse.NewTable(`CREATE TABLE `+tableName+`
-		( "message" String, "timestamp" DateTime64(3, 'UTC') )
-		ENGINE = Memory`,
-		clickhouse.NewNoTimestampOnlyStringAttrCHConfig(),
-	)
-	if err != nil {
-		t.Fatal(err)
-	}
-	lm := clickhouse.NewLogManager(util.NewSyncMapWith(tableName, table), &config.QuesmaConfiguration{})
-	s := schema.StaticRegistry{
-		Tables: map[schema.IndexName]schema.Schema{
-			"logs-generic-default": {
-				Fields: map[schema.FieldName]schema.Field{
-					"host.name":         {PropertyName: "host.name", InternalPropertyName: "host.name", Type: schema.QuesmaTypeObject},
-					"type":              {PropertyName: "type", InternalPropertyName: "type", Type: schema.QuesmaTypeText},
-					"name":              {PropertyName: "name", InternalPropertyName: "name", Type: schema.QuesmaTypeText},
-					"content":           {PropertyName: "content", InternalPropertyName: "content", Type: schema.QuesmaTypeText},
-					"message":           {PropertyName: "message", InternalPropertyName: "message", Type: schema.QuesmaTypeText},
-					"host_name.keyword": {PropertyName: "host_name.keyword", InternalPropertyName: "host_name.keyword", Type: schema.QuesmaTypeKeyword},
-					"FlightDelay":       {PropertyName: "FlightDelay", InternalPropertyName: "FlightDelay", Type: schema.QuesmaTypeText},
-					"Cancelled":         {PropertyName: "Cancelled", InternalPropertyName: "Cancelled", Type: schema.QuesmaTypeText},
-					"FlightDelayMin":    {PropertyName: "FlightDelayMin", InternalPropertyName: "FlightDelayMin", Type: schema.QuesmaTypeText},
-					"_id":               {PropertyName: "_id", InternalPropertyName: "_id", Type: schema.QuesmaTypeText},
-				},
-			},
-		},
-	}
-
-	cw := ClickhouseQueryTranslator{ClickhouseLM: lm, Table: table, Ctx: context.Background(), Schema: s.Tables[schema.IndexName("logs-generic-default")]}
-	for _, tt := range tests {
-		t.Run("test", func(t *testing.T) {
-			simpleQuery, _, _ := cw.ParseQueryAsyncSearch(tt)
-			assert.True(t, simpleQuery.CanParse)
-		})
-	}
-}
-
 func Test_parseSortFields(t *testing.T) {
 	tests := []struct {
 		name        string