Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 1f74215

Browse files
committed
Using ExecutionPlan constructor
1 parent ce9a845 commit 1f74215

File tree

4 files changed

+23
-30
lines changed

4 files changed

+23
-30
lines changed

platform/frontend_connectors/schema_transformer_test.go

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -499,9 +499,7 @@ func Test_ipRangeTransform(t *testing.T) {
499499
q.Schema = currentSchema
500500
q.Indexes = []string{q.TableName}
501501
}
502-
plan := &model.ExecutionPlan{
503-
Queries: queries[k],
504-
}
502+
plan := model.NewExecutionPlan(queries[k], nil)
505503

506504
resultPlan, err := transform.Transform(plan)
507505
assert.NoError(t, err)
@@ -742,9 +740,10 @@ func Test_arrayType(t *testing.T) {
742740
t.Run(util.PrettyTestName(tt.name, i), func(t *testing.T) {
743741
tt.query.Schema = indexSchema
744742
tt.query.Indexes = []string{tt.query.TableName}
745-
plan := &model.ExecutionPlan{
746-
Queries: []*model.Query{tt.query},
747-
}
743+
plan := model.NewExecutionPlan(
744+
[]*model.Query{tt.query},
745+
nil,
746+
)
748747
actual, err := transform.Transform(plan)
749748
assert.NoError(t, err)
750749

@@ -1810,9 +1809,10 @@ func Test_mapKeys(t *testing.T) {
18101809
tt.query.Indexes = []string{tt.query.TableName}
18111810
var actual *model.ExecutionPlan
18121811
var err error
1813-
plan := &model.ExecutionPlan{
1814-
Queries: []*model.Query{tt.query},
1815-
}
1812+
plan := model.NewExecutionPlan(
1813+
[]*model.Query{tt.query},
1814+
nil,
1815+
)
18161816
if indexConfig[tt.query.TableName].EnableFieldMapSyntax {
18171817
actual, err = transformPass.Transform(plan)
18181818
} else {
@@ -1905,9 +1905,10 @@ func Test_cluster(t *testing.T) {
19051905
tt.query.Schema = indexSchema
19061906
tt.query.Indexes = []string{tt.query.TableName}
19071907

1908-
plan := &model.ExecutionPlan{
1909-
Queries: []*model.Query{tt.query},
1910-
}
1908+
plan := model.NewExecutionPlan(
1909+
[]*model.Query{tt.query},
1910+
nil,
1911+
)
19111912
actual, err := transform.Transform(plan)
19121913
assert.NoError(t, err)
19131914

platform/frontend_connectors/search_ab_testing.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,11 @@ func (q *QueryRunner) executeABTesting(ctx context.Context, plan *model.Executio
134134

135135
case *quesma_api.ConnectorDecisionElastic:
136136
planExecutor = func(ctx context.Context) ([]byte, error) {
137-
elasticPlan := &model.ExecutionPlan{
138-
IndexPattern: plan.IndexPattern,
139-
QueryRowsTransformers: []model.QueryRowsTransformer{},
140-
Queries: []*model.Query{},
141-
StartTime: plan.StartTime,
142-
Name: config.ElasticsearchTarget,
143-
}
137+
elasticPlan := model.NewExecutionPlan(
138+
[]*model.Query{}, []model.QueryRowsTransformer{})
139+
elasticPlan.Name = config.ElasticsearchTarget
140+
elasticPlan.IndexPattern = plan.IndexPattern
141+
elasticPlan.StartTime = plan.StartTime
144142
return q.executePlanElastic(ctx, elasticPlan, body, optAsync, optComparePlansCh, isMainPlan)
145143
}
146144

platform/optimize/pipeline_test.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@ func Test_cacheQueries(t *testing.T) {
5858
TableName: tt.tableName,
5959
},
6060
}
61-
plan := &model.ExecutionPlan{
62-
Queries: queries,
63-
}
61+
plan := model.NewExecutionPlan(queries, nil)
6462
pipeline := NewOptimizePipeline(&cfg)
6563
optimized, err := pipeline.Transform(plan)
6664
if err != nil {
@@ -214,9 +212,7 @@ func Test_dateTrunc(t *testing.T) {
214212
SelectCommand: tt.query,
215213
},
216214
}
217-
plan := &model.ExecutionPlan{
218-
Queries: queries,
219-
}
215+
plan := model.NewExecutionPlan(queries, nil)
220216
pipeline := NewOptimizePipeline(&cfg)
221217
optimized, err := pipeline.Transform(plan)
222218

@@ -453,9 +449,7 @@ func Test_materialized_view_replace(t *testing.T) {
453449
SelectCommand: tt.query,
454450
},
455451
}
456-
plan := &model.ExecutionPlan{
457-
Queries: queries,
458-
}
452+
plan := model.NewExecutionPlan(queries, nil)
459453
pipeline := NewOptimizePipeline(&cfg)
460454
optimized, err := pipeline.Transform(plan)
461455

platform/parsers/elastic_query_dsl/query_parser.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func (cw *ClickhouseQueryTranslator) ParseQuery(body types.JSON) (*model.Executi
4343
simpleQuery, hitsInfo, highlighter, err := cw.parseQueryInternal(body)
4444
if err != nil || !simpleQuery.CanParse {
4545
logger.WarnWithCtx(cw.Ctx).Msgf("error parsing query: %v", err)
46-
return &model.ExecutionPlan{}, err
46+
return model.NewExecutionPlan(nil, nil), err
4747
}
4848

4949
var queries []*model.Query
@@ -74,7 +74,7 @@ func (cw *ClickhouseQueryTranslator) ParseQuery(body types.JSON) (*model.Executi
7474

7575
runtimeMappings, err := ParseRuntimeMappings(body) // we apply post query transformer for certain aggregation types
7676
if err != nil {
77-
return &model.ExecutionPlan{}, err
77+
return model.NewExecutionPlan(nil, nil), err
7878
}
7979

8080
// we apply post query transformer for certain aggregation types

0 commit comments

Comments
 (0)