Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 32af378

Browse files
authored
[small] fix 1 test expected answers (#969)
1 parent 5a41028 commit 32af378

File tree

2 files changed

+62
-37
lines changed

2 files changed

+62
-37
lines changed

quesma/queryparser/pancake_sql_query_generation_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ func TestPancakeQueryGeneration(t *testing.T) {
6363
if test.TestName == "multiple buckets_path(file:clients/clover,nr:1)" {
6464
t.Skip("This needs fixing ASAP, easy to fix")
6565
}
66-
if test.TestName == "Clover(file:clients/clover,nr:6)" {
67-
t.Skip("answers are fine, need to update test")
68-
}
6966

7067
if test.TestName == "max_bucket. Reproduce: Visualize -> Line: Metrics: Max Bucket (Bucket: Filters, Metric: Sum)(file:opensearch-visualize/pipeline_agg_req,nr:20)" ||
7168
test.TestName == "complex max_bucket. Reproduce: Visualize -> Line: Metrics: Max Bucket (Bucket: Filters, Metric: Sum), Buckets: Split chart: Rows -> Range(file:opensearch-visualize/pipeline_agg_req,nr:21)" {

quesma/testdata/clients/clover.go

Lines changed: 62 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1007,41 +1007,69 @@ var CloverTests = []testdata.AggregationTestCase{
10071007
"total": 1
10081008
},
10091009
"aggregations": {
1010-
"sampler": {
1011-
"doc_count": 4675,
1012-
"eventRate": {
1013-
"buckets": [
1014-
{
1015-
"doc_count": 442,
1016-
"key": 1726351200000,
1017-
"key_as_string": "2024-09-14T22:00:00.000"
1018-
},
1019-
{
1020-
"doc_count": 0,
1021-
"key": 1726353000000,
1022-
"key_as_string": "2024-09-14T22:30:00.000"
1023-
},
1024-
{
1025-
"doc_count": 0,
1026-
"key": 1726354800000,
1027-
"key_as_string": "2024-09-14T23:00:00.000"
1028-
},
1029-
{
1030-
"doc_count": 0,
1031-
"key": 1726356600000,
1032-
"key_as_string": "2024-09-14T23:30:00.000"
1033-
},
1034-
{
1035-
"doc_count": 0,
1036-
"key": 1726356600000,
1037-
"key_as_string": "2024-09-15T00:00:00.000"
1038-
},
1039-
{
1040-
"doc_count": 1,
1041-
"key": 1728777600000,
1042-
"key_as_string": "2024-09-15T00:30:00.000"
1010+
"q": {
1011+
"meta": {
1012+
"type": "split"
1013+
},
1014+
"buckets": {
1015+
"!str_field:CRASH": {
1016+
"doc_count": 4675,
1017+
"time_buckets": {
1018+
"meta": {
1019+
"type": "time_buckets"
1020+
},
1021+
"buckets": [
1022+
{
1023+
"doc_count": 442,
1024+
"key": 1726351200000,
1025+
"key_as_string": "2024-09-14T22:00:00.000",
1026+
"sum(count)": {
1027+
"value": 442
1028+
}
1029+
},
1030+
{
1031+
"doc_count": 0,
1032+
"key": 1726353000000,
1033+
"key_as_string": "2024-09-14T22:30:00.000",
1034+
"sum(count)": {
1035+
"value": null
1036+
}
1037+
},
1038+
{
1039+
"doc_count": 0,
1040+
"key": 1726354800000,
1041+
"key_as_string": "2024-09-14T23:00:00.000",
1042+
"sum(count)": {
1043+
"value": null
1044+
}
1045+
},
1046+
{
1047+
"doc_count": 0,
1048+
"key": 1726356600000,
1049+
"key_as_string": "2024-09-14T23:30:00.000",
1050+
"sum(count)": {
1051+
"value": null
1052+
}
1053+
},
1054+
{
1055+
"doc_count": 0,
1056+
"key": 1726358400000,
1057+
"key_as_string": "2024-09-15T00:00:00.000",
1058+
"sum(count)": {
1059+
"value": null
1060+
}
1061+
},
1062+
{
1063+
"doc_count": 1,
1064+
"key": 1726360200000,
1065+
"key_as_string": "2024-09-15T00:30:00.000",
1066+
"sum(count)": {
1067+
"value": 1
1068+
}
1069+
}
1070+
]
10431071
}
1044-
]
1072+
}
10451073
}
10461074
}
10471075
},

0 commit comments

Comments
 (0)