Discovered table should not be virtual by default (#932)

pdelewski · web-flow · commit 3b7cce649ef1 · 2024-10-31T08:31:54.000Z
Following config 
```
  '*':
    target: [ my-clickhouse-data-source ]
```
lead to wrong decision about using `common table`
diff --git a/quesma/clickhouse/table_discovery.go b/quesma/clickhouse/table_discovery.go
@@ -283,7 +283,8 @@ func (td *tableDiscovery) autoConfigureTables(tables map[string]map[string]colum
 		} else {
 			maybeTimestampField = td.tableTimestampField(databaseName, table, ClickHouse)
 		}
-		configuredTables[table] = discoveredTable{table, databaseName, columns, config.IndexConfiguration{}, comment, createTableQuery, maybeTimestampField, true}
+		const isVirtualTable = false
+		configuredTables[table] = discoveredTable{table, databaseName, columns, config.IndexConfiguration{}, comment, createTableQuery, maybeTimestampField, isVirtualTable}
 
 	}
 	for tableName, table := range configuredTables {

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,8 @@ func (td *tableDiscovery) autoConfigureTables(tables map[string]map[string]colum`
`283`	`283`	`} else {`
`284`	`284`	`maybeTimestampField = td.tableTimestampField(databaseName, table, ClickHouse)`
`285`	`285`	`}`
`286`		`- configuredTables[table] = discoveredTable{table, databaseName, columns, config.IndexConfiguration{}, comment, createTableQuery, maybeTimestampField, true}`
	`286`	`+ const isVirtualTable = false`
	`287`	`+ configuredTables[table] = discoveredTable{table, databaseName, columns, config.IndexConfiguration{}, comment, createTableQuery, maybeTimestampField, isVirtualTable}`
`287`	`288`
`288`	`289`	`}`
`289`	`290`	`for tableName, table := range configuredTables {`