Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 41c2a02

Browse files
authored
Quickfix failing e2e (#1257)
I run e2e twice now and no errors. It failed because of: * data race with logger in the test * sometimes flaky 1 aggregation test, mistype and it had `15` and `25` in 2 places, where the number must be the same (result of the same query) Sorry for the issue, my PR a few days ago introduced the first error.
1 parent cb26116 commit 41c2a02

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

quesma/quesma/search_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import (
1010
"github.com/DATA-DOG/go-sqlmock"
1111
"github.com/QuesmaOrg/quesma/quesma/backend_connectors"
1212
"github.com/QuesmaOrg/quesma/quesma/clickhouse"
13-
"github.com/QuesmaOrg/quesma/quesma/logger"
1413
"github.com/QuesmaOrg/quesma/quesma/model"
1514
"github.com/QuesmaOrg/quesma/quesma/quesma/config"
1615
"github.com/QuesmaOrg/quesma/quesma/quesma/types"
@@ -862,7 +861,7 @@ func TestSearchTrackTotalCount(t *testing.T) {
862861
}
863862

864863
func TestFullQueryTestWIP(t *testing.T) {
865-
logger.InitSimpleLoggerForTests()
864+
// logger.InitSimpleLoggerForTests()
866865
s := &schema.StaticRegistry{Tables: map[schema.IndexName]schema.Schema{}}
867866

868867
s.Tables[tableName] = schema.Schema{

quesma/testdata/aggregation_requests.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1378,7 +1378,7 @@ var AggregationTests = []AggregationTestCase{
13781378
Cols: []model.QueryResultCol{
13791379
model.NewQueryResultCol("aggr__origins__parent_count", uint64(13014)),
13801380
model.NewQueryResultCol("aggr__origins__key_0", "DLH"),
1381-
model.NewQueryResultCol("aggr__origins__count", int64(15)),
1381+
model.NewQueryResultCol("aggr__origins__count", int64(25)),
13821382
model.NewQueryResultCol("top_hits__origins__originLocation_col_0", map[string]interface{}{
13831383
"lat": "46.84209824",
13841384
"lon": "-92.19360352",

0 commit comments

Comments
 (0)