Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 4a9817e

Browse files
authored
Remove table verifier (#979)
Produces a lot of noisy and confusing log lines. Remove that.
1 parent 2cbc0da commit 4a9817e

File tree

3 files changed

+0
-85
lines changed

3 files changed

+0
-85
lines changed

quesma/clickhouse/table_discovery.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ type TableDiscovery interface {
4545
type tableDiscovery struct {
4646
cfg *config.QuesmaConfiguration
4747
dbConnPool *sql.DB
48-
tableVerifier tableVerifier
4948
tableDefinitions *atomic.Pointer[TableMap]
5049
tableDefinitionsAccessUnixSec atomic.Int64
5150
tableDefinitionsLastReloadUnixSec atomic.Int64
@@ -164,7 +163,6 @@ func (td *tableDiscovery) ReloadTableDefinitions() {
164163
configuredTables = td.readVirtualTables(configuredTables)
165164

166165
td.ReloadTablesError = nil
167-
td.verify(configuredTables)
168166
td.populateTableDefinitions(configuredTables, databaseName, td.cfg)
169167
}
170168

@@ -389,17 +387,6 @@ func (td *tableDiscovery) TableDefinitions() *TableMap {
389387
return td.tableDefinitions.Load()
390388
}
391389

392-
func (td *tableDiscovery) verify(tables map[string]discoveredTable) {
393-
for _, table := range tables {
394-
logger.Info().Msgf("verifying table %s", table.name)
395-
if correct, violations := td.tableVerifier.verify(table); correct {
396-
logger.Debug().Msgf("table %s verified", table.name)
397-
} else {
398-
logger.Warn().Msgf("table %s verification failed: %s", table.name, violations)
399-
}
400-
}
401-
}
402-
403390
func resolveColumn(colName, colType string) *Column {
404391
isNullable := false
405392
if isNullableType(colType) {

quesma/clickhouse/table_verification.go

Lines changed: 0 additions & 22 deletions
This file was deleted.

quesma/clickhouse/table_verification_test.go

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)