Introducing logical fromUnixTime func

Author: pdelewski

platform/frontend_connectors/schema_transformer.go

@@ -912,8 +912,9 @@ func (s *SchemaCheckPass) convertQueryDateTimeFunctionToClickhouse(indexSchema s
 			}
 			return model.NewFunction("toHour", e.Args[0].Accept(b).(model.Expr))
 
-			// TODO this is a place for over date/time related functions
-			// add more
+		case model.FromUnixTimeFunction:
+			args := b.VisitChildren(e.Args)
+			return model.NewFunction("fromUnixTimestamp64Milli", args...)
 
 		default:
 			return visitFunction(b, e)
@@ -941,9 +942,9 @@ func (s *SchemaCheckPass) convertQueryDateTimeFunctionToDoris(indexSchema schema
 				return e
 			}
 			return model.NewFunction("HOUR", e.Args[0].Accept(b).(model.Expr))
-
-			// TODO this is a place for over date/time related functions
-			// add more
+		case model.FromUnixTimeFunction:
+			args := b.VisitChildren(e.Args)
+			return model.NewFunction("FROM_UNIXTIME", args...)
 
 		default:
 			return visitFunction(b, e)
@@ -1083,7 +1084,7 @@ func (s *SchemaCheckPass) acceptIntsAsTimestamps(indexSchema schema.Schema, quer
 				}
 			}
 			if ok {
-				if f, okF := model.ToFunction(expr); okF && f.Name == "fromUnixTimestamp64Milli" && len(f.Args) == 1 {
+				if f, okF := model.ToFunction(expr); okF && f.Name == model.FromUnixTimeFunction && len(f.Args) == 1 {
 					if l, okL := model.ToLiteral(f.Args[0]); okL {
 						if _, exists := l.Format(); exists { // heuristics: it's a date <=> it has a format
 							return model.NewInfixExpr(col, e.Op, f.Args[0])
@@ -1105,7 +1106,7 @@ func (s *SchemaCheckPass) acceptIntsAsTimestamps(indexSchema schema.Schema, quer
 		if f.Name == "toTimezone" && len(f.Args) == 2 {
 			if col, ok := model.ExtractColRef(f.Args[0]); ok && table.IsInt(col.ColumnName) {
 				// adds fromUnixTimestamp64Milli
-				return model.NewFunction("toTimezone", model.NewFunction("fromUnixTimestamp64Milli", f.Args[0]), f.Args[1])
+				return model.NewFunction("toTimezone", model.NewFunction(model.FromUnixTimeFunction, f.Args[0]), f.Args[1])
 			}
 		}
 		return visitFunction(b, f)

platform/frontend_connectors/schema_transformer_test.go

@@ -2039,7 +2039,7 @@ func Test_acceptIntsAsTimestamps(t *testing.T) {
 										model.NewInfixExpr(
 											model.NewFunction("timeZoneOffset", model.NewFunction(
 												"toTimezone",
-												model.NewFunction("fromUnixTimestamp64Milli", model.NewColumnRef("timestampInt")),
+												model.NewFunction(model.FromUnixTimeFunction, model.NewColumnRef("timestampInt")),
 												model.NewLiteral("'Europe/Warsaw'")),
 											),
 											"*",