Done

trzysiek · trzysiek · commit 7129563d5c1a · 2024-11-12T21:31:23.000+01:00
diff --git a/quesma/model/metrics_aggregations/common.go b/quesma/model/metrics_aggregations/common.go
@@ -50,7 +50,6 @@ func metricsTranslateSqlResponseToJsonWithFieldTypeCheck(
 
 func resultRowsAreFine(ctx context.Context, rows []model.QueryResultRow) bool {
 	if len(rows) == 0 {
-		logger.WarnWithCtx(ctx).Msg("no rows returned for metrics aggregation")
 		return false
 	}
 	if len(rows[0].Cols) == 0 {
diff --git a/quesma/queryparser/pancake_json_rendering.go b/quesma/queryparser/pancake_json_rendering.go
@@ -36,7 +36,6 @@ func (p *pancakeJSONRenderer) selectMetricRows(metricName string, rows []model.Q
 		}
 		return []model.QueryResultRow{newRow}
 	}
-	logger.ErrorWithCtx(p.ctx).Msgf("no rows in selectMetricRows %s", metricName)
 	return
 }
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,6 @@ func metricsTranslateSqlResponseToJsonWithFieldTypeCheck(`
`50`	`50`
`51`	`51`	`func resultRowsAreFine(ctx context.Context, rows []model.QueryResultRow) bool {`
`52`	`52`	`if len(rows) == 0 {`
`53`		`- logger.WarnWithCtx(ctx).Msg("no rows returned for metrics aggregation")`
`54`	`53`	`return false`
`55`	`54`	`}`
`56`	`55`	`if len(rows[0].Cols) == 0 {`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ func (p *pancakeJSONRenderer) selectMetricRows(metricName string, rows []model.Q`
`36`	`36`	`}`
`37`	`37`	`return []model.QueryResultRow{newRow}`
`38`	`38`	`}`
`39`		`- logger.ErrorWithCtx(p.ctx).Msgf("no rows in selectMetricRows %s", metricName)`
`40`	`39`	`return`
`41`	`40`	`}`
`42`	`41`